Fix connection leak in post_logs #34
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed we have a bunch of connections stuck in
CLOSE_WAITto Statsig on our Ruby servers using this SDK. I was able to fix this by callingflushon the response frompostinpost_logs, which consumes the response body.Note that I do still see some connections in CLOSE_WAIT to a Cloudflare IP address too, so there may be other cases that this doesn't fix -- however this was the most egregious in our case.
Reproducing
Run the following:
and then observe the connections accumulate..
$ netstat -an | grep CLOSE_WAIT tcp4 0 0 192.168.5.133.65320 34.128.128.0.443 CLOSE_WAIT tcp4 0 0 192.168.5.133.65232 34.128.128.0.443 CLOSE_WAIT tcp4 0 0 192.168.5.133.65219 34.128.128.0.443 CLOSE_WAIT