Cleanups, bump stint/stew #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* prefer stew/staticfor * cleanup pragmas * unroll a few more things These simplifications also bring a nice little 10-15% perf boost: ``` arnetheduck@praeceps:~/status/nimbus-eth1/vendor/nim-bncurve$ /home/arnetheduck/status/nimbus-eth1/vendor/nim-bncurve/benchmarks/bench G1 Jacobian add: 578 ns G1 toAffine: 3067 ns G2 Jacobian add: 3141 ns G2 toAffine: 3772 ns G1 Jacobian mul: 191442 ns G2 Jacobian mul: 819047 ns Pairing: 2111668 ns arnetheduck@praeceps:~/status/nimbus-eth1/vendor/nim-bncurve$ /home/arnetheduck/status/nimbus-eth1/vendor/nim-bncurve/benchmarks/bench G1 Jacobian add: 497 ns G1 toAffine: 2774 ns G2 Jacobian add: 2701 ns G2 toAffine: 3461 ns G1 Jacobian mul: 147267 ns G2 Jacobian mul: 633992 ns Pairing: 1816686 ns ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These simplifications also bring a nice little 10-15% perf boost: