Conversation
arnetheduck
reviewed
Jan 13, 2021
|
|
||
| if i > 0: | ||
| waiters.delete(0, i - 1) | ||
| # Workaround for callSoon() not worked correctly before |
Member
There was a problem hiding this comment.
callSoon calls getThreadDispatcher, why should this be needed here?
arnetheduck
reviewed
Jan 13, 2021
|
|
||
| proc release*(asem: AsyncSemaphore) = | ||
| ## Release a semaphore, incrementing internal counter by one. | ||
| if asem.counter >= asem.maxcounter: |
arnetheduck
reviewed
Jan 13, 2021
| ## If the internal counter is larger than zero on entry, decrement it by one | ||
| ## and return immediately. If its zero on entry, block and wait until some | ||
| ## other task has called ``release()`` to make it larger than 0. | ||
| while asem.counter <= 0: |
Member
There was a problem hiding this comment.
the loop should not be needed here - there will be exactly one queue item per count below zero so they should line up perfectly
vladopajic
force-pushed
the
semaphore
branch
2 times, most recently
from
3a40a3c to
491ddff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.