AsyncEventQueue: add resetRegistration() to continue using the same r…#322
Open
dbrignoli wants to merge 1 commit into
Open
AsyncEventQueue: add resetRegistration() to continue using the same r…#322dbrignoli wants to merge 1 commit into
dbrignoli wants to merge 1 commit into
Conversation
…egistration key after AsyncEventQueueFullError
Contributor
Author
|
Mentioning @cheatfate as he authored AsyncEventQueue 😃 |
Collaborator
|
why do you need to reset? I'm not sure i understand why you need to perform unregister/register sequence, if you can just continue working/handling events. Because your procedure does not do anything helpful actually - pending events still going to be scheduled, so what the reason? |
Contributor
Author
|
@cheatfate, my understanding is that once The reset would allow to keep using the same reader (using the same key) by resetting it after handling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…egistration key after AsyncEventQueueFullError
With EventBus being deprecated I am checking how to move exiting code to AsyncEventQueue and was wondering if the addition of
resetRegistration()(tentative proc name) would be acceptable. It could be used when tasks catchAsyncEventQueueFullErrorand handle/log the occurence but then continue receiving events using the same key instead of getting a new one.