http: add absolute request-target support (fixes #193)#651
Open
arnetheduck wants to merge 4 commits into
Open
Conversation
Member
Author
|
this is an alternative to #618 |
cheatfate
reviewed
May 29, 2026
| # the tracker so it's safe to spawn here - a bit ugly though, | ||
| # would be better to add a "regular" way of doing this | ||
| asyncSpawn treader.closeWait() | ||
| asyncSpawn twriter.closeWait() |
Collaborator
There was a problem hiding this comment.
Please do not use asyncSpawn in core code.
await allFutures(treader.closeWait(), twriter.closeWait())allFutures() is also NOP here if treader.closeWait() and twriter.closeWait() will return finished Futures.
Member
Author
There was a problem hiding this comment.
new is not async so that can't be done easily .. probably the easiest thing to do is to remove the TLSStreamInitError entirely, or change how asyncstreams are created and closed so that they don't need closing if they haven't been used but both changes seem out of scope here .. can also remove the fix entirely and let them leak but this TODO seemed like a reasonable compromise.
cheatfate
reviewed
May 29, 2026
arnetheduck
commented
May 29, 2026
arnetheduck
commented
May 31, 2026
arnetheduck
commented
May 31, 2026
Using an absolute request URI and a connection provider that connects to a different server than the http address, generic proxies can be implemented * add detail to http connection error * fix transport/stream leak when http client construction fails
Co-authored-by: Jacek Sieka <arnetheduck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using an absolute request URI and a connection provider that connects to a different server than the http address, generic proxies can be implemented