Fix #112; add results.Opt support#123
Merged
Merged
Conversation
Contributor
|
please rebase |
nitely
force-pushed
the
nitely_fix_112
branch
from
December 17, 2025 19:04
bc40769 to
66fd952
Compare
nitely
force-pushed
the
nitely_fix_112
branch
from
December 17, 2025 19:07
66fd952 to
551d076
Compare
jangko
approved these changes
Dec 18, 2025
Member
we usually manage to isolate these changes somewhat at least, but in general the plan is to go 100% Opt so every step in that direction is useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #112
Alternatively it could be moved to a
confutils/pkg/results, but since it's used internally and would need to be exported anyway, I think there is no point in that.Note I tried changing Optional to results.Opt in nimbus-eth2, but to do so it requires switching throughout (otherwise is a PITA). That means adding Opt support to nim-presto and nim-toml-ser, maybe other libs too (nim-eth db but I don't think so).