add response duration metric historgram with buckets#92
Open
jakubgs wants to merge 1 commit into
Open
Conversation
This way we can measure spread of latencies across multiple requests over time and not just duration time of the last request made. Personally I think presto_server_prepare_response_time metric is almost useless because high latency responses can be easily lost because the next set() call can reset the value back to a normal looking one. Removing it entirely might be even better. Signed-off-by: Jakub Sokołowski <jakub@status.im>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This way we can measure spread of latencies across multiple requests over time and not just duration time of the last request made.
Example:
Personally I think
presto_server_prepare_response_timemetric is almost useless because high latency responses can be easily lost because the nextset()call can reset the value back to a normal looking one.Removing it entirely might be even better. Happy to do that if people agree.