Conversation
beacon_chain/nimbus_beacon_node.nim
Outdated
| if true: | ||
| return | ||
| # # Currently, this logic is broken | ||
| # if true: |
There was a problem hiding this comment.
Can just remove this if entirely, rather than commenting it out.
| localIndices[j] = idxArr[j] | ||
| localCells[j] = cellsArr[j] | ||
| # use the task wrapper which maps string errors to void | ||
| recoverCellsAndKzgProofsTask(localIndices, localCells) |
There was a problem hiding this comment.
there is no need for this seq as far as I can tell - just change the argument type of ...Task to openArray, then use idxArr.toOpenArray(0, columnCount - 1)
| break # Stop spawning new tasks | ||
| trace "PeerDAS reconstruction timed out while preparing columns", | ||
| spawned = spawned, total = blobCount | ||
| return err("Data column reconstruction timed out") |
There was a problem hiding this comment.
what happens to the tasks that are still pending here? presumably, they still reference the memory allocated by pendingIndices and pendingCells?
There was a problem hiding this comment.
in that case, we need to drain all the pending tasks, one more thing we can probably do instead of an early return is to use a timeout flag, and check if we have timed out before spawning newer tasks, that way the number of pending tasks may get lower, however, timeout won't be strict in that sense, as we would wait to drain the pending tasks, but should be memory safe, most likely.
(i have made some more changes)
|
beacon_chain/conf.nim
Outdated
| desc: "Subscribe to the first half of column subnets" | ||
| name: "light-supernode" .}: bool | ||
|
|
||
| debugDisableReconstruction* {. |
There was a problem hiding this comment.
let's avoid the double negative here .. ie --debug-enable-reconstruction instead
3 participants
No description provided.