Skip to content

Conversation

@rnkrtt
Copy link
Contributor

@rnkrtt rnkrtt commented Dec 26, 2025

prune() used physical index for currentEpochTips.del but the table is keyed by logical index. Causes wrong entries deleted after first prune.

@tersec
Copy link
Contributor

tersec commented Dec 26, 2025

The linting CI is failing on:

Run excluded_files="config.yaml|config.nims|beacon_chain.nimble"
The following files do not have an up-to-date copyright year:
- beacon_chain/fork_choice/proto_array.nim

i.e.

# Copyright (c) 2018-2024 Status Research & Development GmbH

should be updated to read

# Copyright (c) 2018-2025 Status Research & Development GmbH 

@github-actions
Copy link

github-actions bot commented Dec 26, 2025

Unit Test Results

       12 files  ±0    2 436 suites  ±0   46m 11s ⏱️ - 1m 46s
12 678 tests ±0  12 113 ✔️ ±0  565 💤 ±0  0 ±0 
63 716 runs  ±0  62 988 ✔️ ±0  728 💤 ±0  0 ±0 

Results for commit f8b0cc1. ± Comparison against base commit ced2b9f.

♻️ This comment has been updated with latest results.

@rnkrtt
Copy link
Contributor Author

rnkrtt commented Dec 26, 2025

@tersec did it, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants