feat_: kvstore service integration #17762
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaichaosun
requested review from
a team,
alexjba,
caybro and
micieslak
as code owners
Closed
4 tasks
Member
Jenkins Builds
|
alexjba
reviewed
Apr 9, 2025
Contributor
alexjba
left a comment
alexjba
left a comment
There was a problem hiding this comment.
LGTM in general! 👍
Two minor questions
| result.QObject.setup | ||
|
|
||
| proc init*(self: Service) = | ||
| let response = status_kvstore.getStoreEntry() |
Contributor
There was a problem hiding this comment.
all proc implementations of status_kvstore can throw. I think we could use some exceptions handling.
| text: qsTr("RPC statistics") | ||
| onClicked: rpcStatsModal.open() | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
What will this setting do for the user?
Adding @jorge-campo in case we need to update the documentation.
Contributor
Author
There was a problem hiding this comment.
It will be used to enable the RLN rate limit. Here are more detail: status-im/status-go#6475
Contributor
Author
|
Close it for logos-messaging/pm#277 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Use kvstore api provided by status-go
Affected areas
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)