chore(e2e_appium): add e2e_appium #18366
Conversation
Jenkins BuildsClick to see older builds (67)
|
glitchminer
force-pushed
the
test/e2e_appium/add-e2e_appium-framework
branch
2 times, most recently
from
06d7424 to
fc30d84
Compare
fbarbu15
left a comment
fbarbu15
left a comment
There was a problem hiding this comment.
Amazing job @glitchminer
This already looks mature and I love the structure
I left some comments, mostly just thinking out loud
|
Why are we doing these e2e test on GitHub and not in Jenkins? Our release pipelines are in Jenkins, and we'll need to run e2e tests for both desktop and mobile for release builds in Jenkins. |
Hi @jakubgs, I agree, they can and should be run in Jenkins as part of the pipelines as well. First though, I think the core functionality of the framework needs completed, which we're targeting for completion in the next few weeks. At the time of planning, there was no CI builds or pipeline available. The idea of adding a workflow dispatch option in the mean time served the purpose of being able to test the functionality of framework itself, which is still under development (there is only a single test flow as POC), before integrating elsewhere. Once the framework is stable with some test coverage, Jenkins pipeline integration will be the immediate next step. The GitHub workflows will then just serve as a convenience to manually specify and initiate ad-hoc testing when needed. |
|
Cool, just keep in mind to not put too much into the Github actions config and keep things re-usable for Jenkins pipelines. Thanks. |
glitchminer
force-pushed
the
test/e2e_appium/add-e2e_appium-framework
branch
3 times, most recently
from
7c2a466 to
846e262
Compare
glitchminer
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
glitchminer
changed the title
glitchminer
force-pushed
the
test/e2e_appium/add-e2e_appium-framework
branch
from
9fa9175 to
e6e8710
Compare
fbarbu15
left a comment
fbarbu15
left a comment
There was a problem hiding this comment.
Thanks. Added one more comment.
Also please share a link in the PR description with a github actions CI run because I cannot find it
test/e2e_appium/locators/onboarding/analytics_screen_locators.py
Outdated
Show resolved
Hide resolved
glitchminer
force-pushed
the
test/e2e_appium/add-e2e_appium-framework
branch
from
0e83a57 to
048a75d
Compare
Thanks @fbarbu15, fixed now. I had tested github action on a different repo which is why it wasn't visible, added an action on push for this branch now (instead of just dispatch) so you can see it. Link in PR description. |
7 participants
closes #18588
What does the PR do
e2e framework for tablet and mobile builds
Initial framework for e2e tablet / mobile builds:
Supporting setup, teardown and 1 fixture for onboarding with password.
Logging and reports in various formats.
Environment:
Able to run on lambdatest and local environment and be triggered by github action using LT URL, URL of APK to upload, run ID of a github action with APK as artifact.
GitHub Action demo
https://github.com/status-im/status-desktop/actions/runs/17068784181
lt.mp4