Skip to content

Conversation

@mmlado
Copy link
Contributor

@mmlado mmlado commented Dec 7, 2025

What does the PR do

In Node management the fields Mailserver interactions, Logs, and JSON-RPC will resize to the available space in the window, keeping roughly 1/3 of the space for themselves.

Fixes #12746

Affected areas

Node management

Architecture compliance

Screencapture of the functionality

fix12746

Impact on end user

Before: If the window was small, the user didn't see all the fields
After: If the window is small, the fields will shrink/grow to the available space in the window.

How to test

  1. Select Node Management in the left pane.
  2. Resize the window such that its vertical dimension is low.
  3. Follow resize of the fields, on smallest size of the window all fields must be visible.

Risk

Cosmetic changes. Minimal risk.

@status-im-auto
Copy link
Member

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ac057c8 #1 2025-12-07 19:53:50 ~21 min linux/x86_64-nwaku 📦tgz

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good 👍

height: 300
Layout.fillWidth: true
Layout.fillHeight: true
Layout.preferredHeight: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the preferredHeight: 0, fillHeight: true should already do the thing right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When multiple items have fillHeight: true QML uses secondary, implicit, parameter for it's height, which by default is based on the based on it's contents, so Logs, as it has the most content, will take up disproportional amount of space compared to the other two sections. With preferredHeight: 0 it's telling it to ignore the natural size preference and to only fill the available space evenly as all the sections have the same preferences for their size.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node Management window is not vertically scrollable

3 participants