Skip to content

Conversation

@alexjba
Copy link
Contributor

@alexjba alexjba commented Dec 8, 2025

What does the PR do

  • Add the sds lib to the app package. The app fails to start due to the missing libsds lib.
  • Fix a typo preventing the app width to be set. 12-08 15:56:58.654 15468 15523 W chronicles: WRN 2025-12-08 13:56:58.651Z qt warning topics="qt" tid=15523 category=default file=qrc:/main.qml:136 text="TypeError: Cannot read property 'width' of undefined"
  • Forward the USE_SYSTEM_NIM flag to status-go compilation for mobile.

@alexjba alexjba requested review from a team, caybro, micieslak and noeliaSD as code owners December 8, 2025 14:03
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the first half of the fix also in the release branch?

@status-im-auto
Copy link
Member

status-im-auto commented Dec 8, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
38f5486 #1 2025-12-08 14:10:33 ~6 min macos/aarch64-nwaku 📄log
✔️ 38f5486 #1 2025-12-08 14:13:04 ~9 min android/arm64 🤖apk 📲
✔️ 38f5486 #1 2025-12-08 14:13:58 ~10 min tests/nim 📄log
✔️ 38f5486 #1 2025-12-08 14:16:53 ~13 min tests/ui 📄log
38f5486 #1 2025-12-08 14:18:19 ~14 min windows/x86_64 📄log
✖️ 38f5486 #1 2025-12-08 14:18:30 ~15 min ios/aarch64 📱ipa
✔️ 38f5486 #1 2025-12-08 14:22:47 ~19 min macos/aarch64 🍎dmg
✔️ 38f5486 #1 2025-12-08 14:23:06 ~19 min linux/x86_64 📦tgz
✔️ 38f5486 #1 2025-12-08 14:25:36 ~22 min linux/x86_64-nwaku 📦tgz
✔️ 38f5486 pr19506 2025-12-08 14:38:20 ~15 min tests/e2e 📊rpt
✔️ 2a2bfa5 #2 2025-12-08 15:28:00 ~9 min android/arm64 🤖apk 📲
✔️ 2a2bfa5 #2 2025-12-08 15:29:06 ~10 min tests/nim 📄log
✔️ 2a2bfa5 #2 2025-12-08 15:32:08 ~13 min tests/ui 📄log
2a2bfa5 #2 2025-12-08 15:33:14 ~14 min windows/x86_64 📄log
✖️ 2a2bfa5 #2 2025-12-08 15:35:55 ~17 min ios/aarch64 📱ipa
✔️ 2a2bfa5 #2 2025-12-08 15:38:27 ~19 min linux/x86_64 📦tgz
✔️ 2a2bfa5 #2 2025-12-08 15:40:11 ~21 min macos/aarch64 🍎dmg
✔️ 2a2bfa5 #2 2025-12-08 15:40:59 ~22 min linux/x86_64-nwaku 📦tgz
✔️ 2a2bfa5 #2 2025-12-08 15:42:20 ~23 min macos/aarch64-nwaku 🍎dmg
✖️ 2a2bfa5 pr19506 2025-12-08 15:54:22 ~15 min tests/e2e 📊rpt
2a2bfa5 #3 2025-12-08 16:01:11 ~14 min windows/x86_64 📄log
2a2bfa5 #4 2025-12-08 17:11:04 ~14 min windows/x86_64 📄log
2a2bfa5 #5 2025-12-08 18:01:58 ~14 min windows/x86_64 📄log

@alexjba alexjba requested a review from a team as a code owner December 8, 2025 15:18
@alexjba
Copy link
Contributor Author

alexjba commented Dec 8, 2025

Is the first half of the fix also in the release branch?

I don’t think the theme and sds commits are in release. But I’ll check

@alaibe alaibe merged commit 140944e into master Dec 8, 2025
11 of 13 checks passed
@alaibe alaibe deleted the fix/Android-app branch December 8, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants