chore: uses system nim everywhere #19537
Open
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins Builds
|
siddarthkay
commented
Dec 9, 2025
| scoop install --global ` | ||
| 7zip git dos2unix findutils ` | ||
| wget rcedit inno-setup ` | ||
| nim mingw-winlibs ` |
Contributor
Author
There was a problem hiding this comment.
added mingw-winlibs because
Running post_install script...done.
'nim' (2.2.6) was installed successfully!
'nim' suggests installing 'mingw-winlibs'.
Contributor
Author
|
for linux builds I need to update jenkins base docker image to contain |
Member
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19537#2 🔹 ~13 min 🔹 fa38b65 🔹 📦 tests/ui package |
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19537#3 🔹 ~14 min 🔹 bb3dffc 🔹 📦 tests/ui package |
Member
Member
siddarthkay
force-pushed
the
fix-nbs-issues-on-windows
branch
from
bb3dffc to
dc216e3
Compare
siddarthkay
changed the title
siddarthkay
requested review from
glitchminer
and removed request for
a team
Member
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19537#4 🔹 ~13 min 🔹 dc216e3 🔹 📦 tests/ui package |
siddarthkay
force-pushed
the
fix-nbs-issues-on-windows
branch
from
dc216e3 to
0a5fb0d
Compare
Member
✔️ status-desktop/prs/android/arm64/package/PR-19537#5 🔹 ~9 min 5 sec 🔹 0a5fb0d 🔹 📦 android/arm64 package |
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19537#5 🔹 ~14 min 🔹 0a5fb0d 🔹 📦 tests/ui package |
Member
Member
alexjba
reviewed
Dec 10, 2025
Contributor
alexjba
left a comment
alexjba
left a comment
There was a problem hiding this comment.
Isn't it an option to preserve the single source of truth for the nim compiler version and use the one compiled by the deps-common make target? I think the USE_SYSTEM_NIM could probably be managed internally for status-go target whenever it's not provided by the user.
I was thinking this would be a good rule to have:
USE_SYSTEM_NIM provided by the user - use it everywhere
USE_SYSTEM_NIM not provided by the user - add the nimbus-build-system nim to PATH and enable USE_SYSTEM_NIM internally for all targets.
Member
Contributor
Author
|
@alexjba : that is an option true, but since This PR merely brings in status-go version with that change : https://github.com/status-im/status-go/pull/7185/changes#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R220 and modifies system scripts to make sure |
Member
Contributor
Author
|
also I would rather avoid |
Contributor
What I meant is that we could probably avoid installing Nim on the host machines altogether (and ask developers to pin a specific local nim version). Instead, the main Makefile could configure the Nim path automatically by using the |
Member
Contributor
Not sure we can avoid it entirely..So unless the nim compilation part is producing these weird errors we're still stuck with these issues. |
igor-sirotin
approved these changes
Dec 10, 2025
jrainville
approved these changes
Dec 10, 2025
Member
✔️ status-desktop/prs/android/arm64/package/PR-19537#6 🔹 ~11 min 🔹 5ff23b4b 🔹 📦 android/arm64 package |
siddarthkay
force-pushed
the
fix-nbs-issues-on-windows
branch
from
0a5fb0d to
26e1b96
Compare
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19537#8 🔹 ~38 min 🔹 26e1b96 🔹 📦 tests/nim package |
Member
✔️ status-app/prs/android/arm64/package/PR-19537#7 🔹 ~1 hr 9 min 🔹 26e1b96 🔹 📦 android/arm64 package |
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19537#6 🔹 ~59 min 🔹 26e1b96 🔹 📦 tests/ui package |
siddarthkay
force-pushed
the
fix-nbs-issues-on-windows
branch
3 times, most recently
from
ba3b2db to
8095b64
Compare
Member
Jenkins BuildsClick to see older builds (44)
|
To fix windows build issues due to very long paths by nimbus-build-system - points status-go to bring in status-im/status-go#7185 - updates mac,windows host install scripts to include nim - updates linux dockerfile to install nim - updates linux docker image tag to use newer image
siddarthkay
force-pushed
the
fix-nbs-issues-on-windows
branch
from
8095b64 to
85115c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix windows build issues due to very long paths by nimbus-build-system