Constants: remove dependency on Theme attached type #19555
+189
−458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micieslak
requested review from
a team,
alexjba,
caybro and
noeliaSD
as code owners
micieslak
requested review from
Khushboo-dev-cpp and
saledjenic
and removed request for
a team
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19555#1 🔹 ~11 min 🔹 9bcb158 🔹 📦 tests/nim package |
Member
Member
Member
✔️ status-app/prs/linux/x86_64/package/PR-19555#1 🔹 ~20 min 🔹 9bcb158 🔹 📦 linux/x86_64 package |
Member
Member
Member
✔️ status-app/e2e/prspr19555 🔹 ~16 min 🔹 9bcb158 🔹 📦 tests/e2e package |
…onent added This commit finally removes dependency on Theme from Constants along with workaround in main.qml which is no longer needed. Closes: #19485
micieslak
force-pushed
the
chore/issue-19485
branch
from
9bcb158 to
02cd432
Compare
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19555#2 🔹 ~12 min 🔹 02cd432 🔹 📦 tests/nim package |
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19555#2 🔹 ~13 min 🔹 02cd432 🔹 📦 tests/ui package |
Member
Member
Member
✔️ status-app/prs/linux/x86_64/package/PR-19555#2 🔹 ~21 min 🔹 02cd432 🔹 📦 linux/x86_64 package |
Member
✔️ status-app/e2e/prs-windowsPR19555 🔹 ~28 min 🔹 9bcb158 🔹 📦 tests/e2e-windows package |
Member
Member
✔️ status-app/e2e/prspr19555 🔹 ~15 min 🔹 02cd432 🔹 📦 tests/e2e package |
Member
Member
✔️ status-app/e2e/prs-windowsPR19555 🔹 ~32 min 🔹 02cd432 🔹 📦 tests/e2e-windows package |
saledjenic
approved these changes
Dec 11, 2025
Member
Jenkins BuildsClick to see older builds (11)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
This PR is follow-up of #19316, making
Constantsfully stateless singleton, with no dependency on attached typeTheme. The workaround done inmain.qmlis removed now.ConstantsConfirmAddingNewMasterKeylayout fixedStatusStepperrefactored, made responsiveConstantsrefactored and cleanedCloses: #19485
Affected areas
Constants.qmland various components using constants.Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines