feat(qr): add new QR library SCodes to scan qr codes#19811
Merged
Conversation
jrainville
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
Member
Jenkins BuildsClick to see older builds (366)
|
1 task
jrainville
force-pushed
the
feat/qr-scanner-design
branch
from
8fbff18 to
9c6904d
Compare
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
from
83aa0ed to
a70b581
Compare
micieslak
reviewed
Jan 29, 2026
micieslak
left a comment
micieslak
left a comment
Member
There was a problem hiding this comment.
I like the new lib, nice replacement for outdated zxing.
Few things:
- I think it's good practice to make for of the lib and refer to that fork. It gives us better control and prevent surprises (like external lib removed and history changed in master)
- please consider using
CMake'sFetchContent. Then config is very simple and limited to single place inCMakeLists.txt, there are some usages already in that file, e.g.:
FetchContent_Declare(
QtModelsToolkit
GIT_REPOSITORY https://github.com/status-im/QtModelsToolkit.git
GIT_TAG af59b81bc10bc37359c2839ae202c160c8321f1a
)
FetchContent_MakeAvailable(QtModelsToolkit)
caybro
reviewed
Jan 29, 2026
caybro
left a comment
caybro
left a comment
Member
There was a problem hiding this comment.
LGTM
Minus what Michal said; let's use a fork with a FetchContent
jrainville
force-pushed
the
feat/qr-scanner-design
branch
from
9c6904d to
28b8e62
Compare
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
3 times, most recently
from
8039b14 to
76ce2f9
Compare
jrainville
force-pushed
the
feat/qr-scanner-design
branch
from
28b8e62 to
cc5b2a8
Compare
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
3 times, most recently
from
90018a9 to
9dc41d9
Compare
jrainville
force-pushed
the
feat/qr-scanner-design
branch
from
cc5b2a8 to
869d9f7
Compare
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
from
fb4106c to
7dae4da
Compare
Member
Author
|
Alright, I finally fixed all the builds. You guys can review |
jrainville
force-pushed
the
feat/qr-scanner-design
branch
from
869d9f7 to
f09775d
Compare
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
from
ee915fa to
312b447
Compare
jrainville
force-pushed
the
feat/qr-scanner-design
branch
from
f09775d to
e5ef90a
Compare
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
from
312b447 to
277afd7
Compare
jrainville
force-pushed
the
feat/qr-scanner-design
branch
from
cbdc365 to
e8ea87c
Compare
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
2 times, most recently
from
8179992 to
c42daf3
Compare
Collaborator
|
Tested build 35
|
Collaborator
|
Tested build 35
|
Collaborator
|
Tested build 35
My Desktop version: Mobile: APK build 35 from this PR Open WEB links - tested. It works. |
Collaborator
|
Tested build 35
|
Collaborator
|
Tested build 35
|
jrainville
force-pushed
the
feat/qr-scanner-design
branch
from
9051b22 to
aa19aed
Compare
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
from
c42daf3 to
ae0a275
Compare
jrainville
force-pushed
the
feat/qr-scanner-design
branch
from
aa19aed to
50d22e2
Compare
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
from
2fd3d90 to
17b0ef0
Compare
Member
Author
|
@sunleos thanks for the tests.
@sunleos you can test again once the build is ready |
Member
Author
|
re 5.: it seems like it was a regression on master. Alex fixed it here: #19940 |
Collaborator
|
Tested APK build 41
1.1. Let's change this crypto icon (it is reserved for payment requests in the app) to the Send icon - sorry, it is my bad, I missed to ask the ui/ux designer to fix it on the mockups. 
Send icon: 1.2. In the Dark mode, the icons are black. If it is a global issue in the app, please skip it. We will fix it separately. 1.3. generally, the copy looks too compact (not much space between the text lines). Is it due to the general scaling issues with our app or something specific to this pop-up? that's what I see on the mockups (a more spacious view): |
Collaborator
Unfortunately, it looks that one second loader is not enough. Let's increase it a bit more if it is reasonable. Screen_Recording_20260212_234350_Status_PR.mp4 |
Member
Collaborator
Ah, sorry about making you change the copy. If it works the way you just described in this line above, then, yes, the copy "cannot" is more appropriate there and works better than "could not" from my perspective as a user. Let's revert the copy back |
Collaborator
Got it. Makes sense. Yeah, we can implement it later if needed. |
Collaborator
Issue: we show the native camera access pop-up on this screen, which is quite premature (the user does know yet that one of the two syncing options works via their device camera - it will be shown on the next screen. Hence, it is a bit confusing to receive this pop-up on that screen). Is it possible to show it on the next screen? If it is a lot of work or complex, leave it as it is. 
|
Collaborator
just tested this PR. Yes, confirming that issue 5 is fixed there :) |
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
from
17b0ef0 to
1c115b0
Compare
jrainville
force-pushed
the
feat/add-new-qr-lib
branch
from
1c115b0 to
475ddbc
Compare
Member
Author
|
@sunleos nice finds. I fixed all the issues you found. I increased the loader to two seconds before showing an error. |
Collaborator
Hey @jrainville, Tested APK build 44 All issues are fixed. Great job!!! 👍 :) Just two small comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do
Part of #19678
Based on top of #19766
Adds a new library to scan QR codes.
The reason is that the one we are using is very old and doesn't support more modern QR codes that are rounded, like the wallet connect ones.
This new lib does support scanning WC codes, though I'll create a new PR to add just the WC support code to the QML.
Affected areas
New lib
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Still works:
new-scan-lib.webm
Impact on end user
None, though scanning QR codes is probably gonna be faster
How to test
Risk
Low-Medium