fix(PrimaryNavSidebar): Improve sizing, positioning and spacing#19935
Merged
Conversation
noeliaSD
requested review from
a team,
alexjba,
caybro and
micieslak
as code owners
noeliaSD
requested review from
Khushboo-dev-cpp,
jrainville and
sunleos
and removed request for
a team and
Khushboo-dev-cpp
noeliaSD
changed the title
Member
Jenkins BuildsClick to see older builds (36)
|
noeliaSD
force-pushed
the
fix/issue-19912
branch
from
9463c85 to
1bd8d5b
Compare
Collaborator
|
Tested APK build 3
|
Collaborator
|
The nav bar and its handle look great to me as is. Tested APK build 3 Two very minor issues are the following. Maybe if they are trivial, we can fix them now. If not, Let's merge this PR as is.
|
noeliaSD
force-pushed
the
fix/issue-19912
branch
from
1bd8d5b to
59aa22b
Compare
noeliaSD
force-pushed
the
fix/issue-19912
branch
from
59aa22b to
2a47d35
Compare
Collaborator
|
Hey @noeliaSD, Tested APK build 5
Two more comments, but not critical ones:
I guess this PR is good to be merged from my point of view. |
sunleos
approved these changes
Feb 13, 2026
jrainville
approved these changes
Feb 13, 2026
- Adjust background color to better match design on both desktop and mobile. - Refine internal spacing and margins between navbar elements and edges. - Increase left margin in portrait mode to provide safe area for floating sidebar. - Improve `SettingsList` margins for better alignment and visual consistency. Closes #19912
… and desktop - Align desktop and mobile behavior where UI main content + nav bar are pushed down. - Ensure TopBanners behave like SafeArea, shifting both NavBar and main content. - Prevent overlapping between banners and navigation/content. Closes #19914
…v bar is collapsed Ensure the Activity Center unread dot/badge is only visible when the nav bar is opened. Prevents visual glitches where the badge was still shown while the sidebar was collapsed. Fixes #19915
noeliaSD
force-pushed
the
fix/issue-19912
branch
from
2a47d35 to
07369bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19912
Closes #19914
Closes #19915
What does the PR do
SettingsListmargins for better alignment and visual consistency.Affected areas
PrimaryNavSidebarSettingsListArchitecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Impact on end user
Better UX
How to test
1. Nav bar sizes / margins
2. Activity Center badge behavior
Screen.Recording.2026-02-13.at.11.02.11.mov
3. Banners
Risk
Low