Skip to content

Conversation

@igor-sirotin
Copy link
Collaborator Author

igor-sirotin commented Nov 13, 2025

@AlbertoSoutullo can you please try this PR?

It fixed the issue for me locally.

@status-im-auto
Copy link
Member

status-im-auto commented Nov 13, 2025

Jenkins Builds

Click to see older builds (41)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 392b3c7 #1 2025-11-13 15:21:40 ~3 min macos/status-go 📦zip
✔️ 392b3c7 #1 2025-11-13 15:21:56 ~3 min linux/status-go 📦zip
✔️ 392b3c7 #1 2025-11-13 15:24:47 ~6 min windows/status-go 📦zip
✔️ 392b3c7 #1 2025-11-13 15:28:55 ~10 min linux/nwaku 📦zip
✔️ 392b3c7 #1 2025-11-13 15:30:42 ~12 min tests-rpc 📄log
✔️ 392b3c7 #1 2025-11-13 15:46:07 ~27 min tests 📄log
392b3c7 #1 2025-12-01 11:17:53 ~7 min macos/nwaku 📄log
392b3c7 #1 2025-12-01 11:32:12 ~6 min windows/nwaku 📄log
✔️ 392b3c7 #1 2025-12-01 12:58:11 ~45 min tests 📄log
✖️ 392b3c7 #1 2025-12-01 13:33:00 ~1 hr 3 min tests-rpc 📄log
✔️ 9377b32 #2 2025-12-08 18:36:45 ~3 min linux/status-go 📦zip
✔️ 9377b32 #2 2025-12-08 18:37:21 ~4 min macos/status-go 📦zip
✔️ 9377b32 #2 2025-12-08 18:40:13 ~7 min windows/status-go 📦zip
✔️ 9377b32 #2 2025-12-08 18:40:30 ~7 min linux/nwaku 📦zip
✔️ 9377b32 #2 2025-12-08 18:41:19 ~8 min macos/nwaku 📦zip
9377b32 #2 2025-12-08 18:43:17 ~10 min windows/nwaku 📄log
✖️ 9377b32 #2 2025-12-08 18:53:25 ~20 min tests-rpc 📄log
✖️ 9377b32 #2 2025-12-08 18:53:30 ~20 min tests-rpc 📄log
✔️ 9377b32 #2 2025-12-08 19:01:19 ~28 min tests 📄log
✔️ 6c3a332 #3 2025-12-08 18:47:14 ~4 min linux/status-go 📦zip
✔️ 6c3a332 #3 2025-12-08 18:47:19 ~4 min macos/status-go 📦zip
✔️ 6c3a332 #3 2025-12-08 18:49:41 ~6 min windows/status-go 📦zip
✔️ 6c3a332 #3 2025-12-08 18:50:53 ~8 min linux/nwaku 📦zip
✔️ 6c3a332 #3 2025-12-08 18:51:30 ~8 min macos/nwaku 📦zip
6c3a332 #3 2025-12-08 18:55:21 ~11 min windows/nwaku 📄log
✖️ 6c3a332 #3 2025-12-08 19:13:28 ~19 min tests-rpc 📄log
✖️ 6c3a332 #3 2025-12-08 19:13:28 ~19 min tests-rpc 📄log
✔️ 6c3a332 #3 2025-12-08 19:27:53 ~26 min tests 📄log
✔️ 6c3a332 #4 2025-12-08 20:18:09 ~12 min tests-rpc 📄log
✔️ 6c3a332 #4 2025-12-08 20:31:51 ~26 min tests 📄log
✔️ a406acd #4 2025-12-08 21:35:31 ~3 min linux/status-go 📦zip
✔️ a406acd #4 2025-12-08 21:36:13 ~4 min macos/status-go 📦zip
✔️ a406acd #4 2025-12-08 21:37:59 ~6 min windows/status-go 📦zip
✔️ a406acd #4 2025-12-08 21:39:36 ~8 min linux/nwaku 📦zip
✔️ a406acd #4 2025-12-08 21:42:54 ~11 min macos/nwaku 📦zip
a406acd #4 2025-12-08 21:43:48 ~11 min windows/nwaku 📄log
✔️ a406acd #4 2025-12-08 21:48:22 ~16 min tests-rpc 📄log
✔️ a406acd #5 2025-12-08 21:49:18 ~17 min tests-rpc 📄log
✔️ a406acd #4 2025-12-08 21:58:52 ~27 min tests 📄log
✖️ a406acd #5 2025-12-08 21:59:11 ~27 min tests 📄log
✔️ a406acd #6 2025-12-08 22:29:36 ~25 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f77663f #5 2025-12-10 10:37:55 ~4 min linux/status-go 📦zip
✔️ f77663f #5 2025-12-10 10:38:07 ~4 min macos/status-go 📦zip
✔️ f77663f #5 2025-12-10 10:41:20 ~7 min linux/nwaku 📦zip
✔️ f77663f #5 2025-12-10 10:41:39 ~7 min windows/status-go 📦zip
✔️ f77663f #5 2025-12-10 10:42:04 ~8 min macos/nwaku 📦zip
f77663f #5 2025-12-10 10:43:45 ~9 min windows/nwaku 📄log
✔️ f77663f #6 2025-12-10 10:50:10 ~16 min tests-rpc 📄log
✔️ f77663f #5 2025-12-10 10:50:17 ~16 min tests-rpc 📄log
✔️ f77663f #7 2025-12-10 10:59:39 ~25 min tests 📄log
✔️ f77663f #5 2025-12-10 10:59:52 ~26 min tests 📄log
a5a22f6 #6 2025-12-11 13:53:18 ~6 min macos/nwaku 📄log
✔️ a5a22f6 #6 2025-12-11 13:54:29 ~7 min macos/status-go 📦zip
✔️ a5a22f6 #6 2025-12-11 13:55:46 ~8 min windows/status-go 📦zip
a5a22f6 #6 2025-12-11 13:58:39 ~11 min windows/nwaku 📄log
✔️ a5a22f6 #6 2025-12-11 14:12:29 ~25 min linux/status-go 📦zip
✔️ a5a22f6 #6 2025-12-11 14:18:37 ~31 min linux/nwaku 📦zip
✔️ a5a22f6 #7 2025-12-11 14:30:19 ~43 min tests-rpc 📄log
✖️ a5a22f6 #6 2025-12-11 14:30:41 ~43 min tests-rpc 📄log
✔️ a5a22f6 #6 2025-12-11 14:40:33 ~53 min tests 📄log
✔️ a5a22f6 #8 2025-12-11 14:40:42 ~53 min tests 📄log

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.66%. Comparing base (a498e69) to head (a5a22f6).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #7105       +/-   ##
============================================
+ Coverage    34.88%   59.66%   +24.77%     
============================================
  Files          807      822       +15     
  Lines       111424   113515     +2091     
============================================
+ Hits         38873    67728    +28855     
+ Misses       67666    38917    -28749     
- Partials      4885     6870     +1985     
Flag Coverage Δ
functional 35.12% <ø> (+0.24%) ⬆️
unit 54.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 518 files with indirect coverage changes

@AlbertoSoutullo
Copy link

What I see now is:

status-backend 2025-11-16T17:26:55.091Z    ERROR    GethStatusBackend.StatusNode.protocol.wakunode.node2.filterv2-lightnode    filter/client.go:376    peer selection returned err    {"error": "no suitable peers found"}
status-backend 2025-11-16T17:26:55.091Z    DEBUG    GethStatusBackend.StatusNode.protocol.filter-api    filter/filter.go:184    failed to resubscribe for filter    {"apisub-id": "8b2eca00-aa28-4b4e-8aac-632a0f0e6307", "content-filter": "{ pubsubTopic: /waku/2/rs/16/32, contentTopics: [ /waku/1/0x68ba9512/rfc26/waku/1/0x162f8f2b/rfc26/waku/1/0xf0f68d67/rfc26 ] }", "error": "no suitable peers found"}

Which I assume it is expected, and I don't see any logs in the bootstrap node, so it looks ok.
But, if I enable filter in the bootstrap node, I get:

2025-11-16T17:32:09.507Z    DEBUG    GethStatusBackend.StatusNode.protocol    waku/gowaku.go:1538    filters did match    {"envelopeHash": "0x9c7f4b8ee170d86a4934698f621fde69c524ea1d24f0c18ce7a9146d06db0809", "pubsubTopic": "/waku/2/rs/16/32", "contentTopic": "/waku/1/0xf497b4c3/rfc26", "timestamp": 1763314329503439432}
2025-11-16T17:32:09.507Z    DEBUG    GethStatusBackend.StatusNode.protocol    pushnotificationclient/client.go:891    messageID not tracked, nothing to do    {"messageID": "trrK15XG5hi8wjJhPPmgPv4C1gLy/R8p08rfZJsk0Z8="}
2025-11-16T17:32:09.507Z    DEBUG    GethStatusBackend.StatusNode.protocol    pushnotificationclient/client.go:894    messageID tracked    {"messageID": "trrK15XG5hi8wjJhPPmgPv4C1gLy/R8p08rfZJsk0Z8="}
2025-11-16T17:32:09.611Z    DEBUG    GethStatusBackend.StatusNode.protocol.filter-api    filter/filter.go:150    subscription status    {"apisub-id": "b1d626ff-ed82-4942-8f38-ea285e4a127c", "content-filter": "{ pubsubTopic: /waku/2/rs/16/32, contentTopics: [ /waku/1/0xf497b4c3/rfc26/waku/1/0x480dc26e/rfc26/waku/1/0xeb512c37/rfc26 ] }", "sub-count": 1, "content-filter": "{ pubsubTopic: /waku/2/rs/16/32, contentTopics: [ /waku/1/0xf497b4c3/rfc26/waku/1/0x480dc26e/rfc26/waku/1/0xeb512c37/rfc26 ] }"}
2025-11-16T17:32:09.611Z    DEBUG    GethStatusBackend.StatusNode.protocol.filter-api    filter/filter.go:174    subscribing again    {"apisub-id": "b1d626ff-ed82-4942-8f38-ea285e4a127c", "content-filter": "{ pubsubTopic: /waku/2/rs/16/32, contentTopics: [ /waku/1/0xf497b4c3/rfc26/waku/1/0x480dc26e/rfc26/waku/1/0xeb512c37/rfc26 ] }", "num-peers": 1}
2025-11-16T17:32:09.611Z    DEBUG    GethStatusBackend.StatusNode.protocol.filter-api    filter/filter.go:203    subscribing with peers to exclude    {"apisub-id": "b1d626ff-ed82-4942-8f38-ea285e4a127c", "content-filter": "{ pubsubTopic: /waku/2/rs/16/32, contentTopics: [ /waku/1/0xf497b4c3/rfc26/waku/1/0x480dc26e/rfc26/waku/1/0xeb512c37/rfc26 ] }", "excluded-peers": ["16Uiu2HAm94BcCzoSZNqK1vye8KsqU5XN2uZGm6kziQnCC94q7QXT"]}
2025-11-16T17:32:09.611Z    DEBUG    GethStatusBackend.StatusNode.protocol.wakunode.node2.filterv2-lightnode    filter/client.go:363    handleFilterSubscribeOptions    {"peerCount": 1, "excludePeersLen": 1}
2025-11-16T17:32:09.611Z    DEBUG    GethStatusBackend.StatusNode.protocol.wakunode.node2.peer-manager    peermanager/peer_selection.go:197    Select Peers    {"selectionCriteria": "{\"selectionType\":0,\"protocolId\":\"/vac/waku/filter-subscribe/2.0.0-beta1\",\"pubsubTopics\":[\"/waku/2/rs/16/32\"],\"specificPeers\":null,\"maxPeerCount\":1,\"excludePeers\":{\"\\u0000%\\b\\u0002\\u0012!\\u0002ʂV\\ufffd\\u0012\\ufffd\\u003c\\ufffd5\\ufffdgy\\ufffd\\ufffd0\\u001d#\\ufffd\\ufffd\\ufffd\\ufffd\\ufffd8͹\\ufffdM\\ufffdxM\\ufffdr\":{}}}", "excludedPeers": "16Uiu2HAm94BcCzoSZNqK1vye8KsqU5XN2uZGm6kziQnCC94q7QXT"}
2025-11-16T17:32:09.611Z    DEBUG    GethStatusBackend.StatusNode.protocol.wakunode.node2.peer-manager    peermanager/peer_selection.go:151    discovering peers by pubsubTopic    {"pubsubTopics": ["/waku/2/rs/16/32"]}
2025-11-16T17:32:09.611Z    DEBUG    GethStatusBackend.StatusNode.protocol.wakunode.node2.peer-manager    peermanager/peer_selection.go:162    could not retrieve random peer from slot
2025-11-16T17:32:09.611Z    ERROR    GethStatusBackend.StatusNode.protocol.wakunode.node2.filterv2-lightnode    filter/client.go:376    peer selection returned err    {"error": "no suitable peers found"}
2025-11-16T17:32:09.611Z    DEBUG    GethStatusBackend.StatusNode.protocol.filter-api    filter/filter.go:184    failed to resubscribe for filter    {"apisub-id": "b1d626ff-ed82-4942-8f38-ea285e4a127c", "content-filter": "{ pubsubTopic: /waku/2/rs/16/32, contentTopics: [ /waku/1/0xf497b4c3/rfc26/waku/1/0x480dc26e/rfc26/waku/1/0xeb512c37/rfc26 ] }", "error": "no suitable peers found"}

Looks like it cannot connect. Also in the nwaku node I see:

INF 2025-11-16 17:34:03.402+00:00 received filter subscribe request          topics="waku filter" tid=7 file=protocol.nim:131 peerId=16U*ren4Uv request="FilterSubscribeRequest of req:1afcadf2acf818e2ebf27437c32c4fb7a12de8a0b492b9e6104956fe7dad82bf [SUBSCRIBER_PING[] pubsubTopic:some(\"\") contentTopics:@]"
INF 2025-11-16 17:35:03.403+00:00 received filter subscribe request          topics="waku filter" tid=7 file=protocol.nim:131 peerId=16U*ren4Uv request="FilterSubscribeRequest of req:6cf6110e1253153ab7c795dcb915ec9751b8b5162fad51ffb830748f2378c53f [SUBSCRIBER_PING[] pubsubTopic:some(\"\") contentTopics:@]"

Looks like it is retrying each minute? Tomorrow will take a deeper look.

@igor-sirotin igor-sirotin force-pushed the fix/7097-filter-peers-by-protocol branch 3 times, most recently from 6c3a332 to a406acd Compare December 8, 2025 21:31
@igor-sirotin igor-sirotin changed the title fix: update go-waku to filter peers by protocol fix: update go-waku Dec 9, 2025
@igor-sirotin igor-sirotin force-pushed the fix/7097-filter-peers-by-protocol branch from a406acd to f77663f Compare December 10, 2025 10:33
@igor-sirotin igor-sirotin marked this pull request as ready for review December 10, 2025 10:33
@igor-sirotin igor-sirotin requested a review from a team as a code owner December 10, 2025 10:33
@igor-sirotin igor-sirotin self-assigned this Dec 10, 2025
@igor-sirotin igor-sirotin force-pushed the fix/7097-filter-peers-by-protocol branch from f77663f to a5a22f6 Compare December 11, 2025 13:46
@igor-sirotin igor-sirotin merged commit 0ed31b7 into develop Dec 11, 2025
24 of 27 checks passed
@igor-sirotin igor-sirotin deleted the fix/7097-filter-peers-by-protocol branch December 11, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants