fix(protocol): guard connection state access#7461
Open
buyua9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Messenger.connectionStatewith a small RW mutex and route mailserver sync gating through accessor helpersmessaging.Core.connectionStatewhile preserving the offline/online reliability transition behaviorFollow-up to #7350, which restored the mobile
ConnectionChangepropagation chain.Why
ConnectionChangedcan run while mailserver sync checks read the current connection state to decide whether expensive networks should be allowed. The restored state cache was read and written directly, which leaves the new connection-state path race-prone under concurrent network changes and store-node sync checks.Validation
git diff --check origin/develop...HEADgo testnot run locally because this environment does not have the Go toolchain installed (go: command not found)