chore: remove CryptoCompare market provider#7490
Open
friofry wants to merge 1 commit into
Open
Conversation
Drop CryptoCompare provider wiring and its tests, and remove market proxy credentials that were only used by the CryptoCompare proxy path.
There was a problem hiding this comment.
Pull request overview
Removes the CryptoCompare market data provider and all related plumbing (config fields, request fields, proxy credentials, tests). Wallet market data lookups now use only CoinGecko (direct + proxy).
Changes:
- Delete the
cryptocompareprovider package and its unit/network tests; remove its usage from wallet service initialization. - Drop
StatusProxyMarketUser/StatusProxyMarketPasswordfromWalletConfig,WalletSecretsConfig, default builder, sensitive-log redaction, and functional test setup. - Remove the
statusProxyStageNameparameter fromwallet.NewService/createWalletServiceand update callers and CoinGecko-only doc comments.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| services/wallet/thirdparty/market/cryptocompare/client.go | Deleted provider client. |
| services/wallet/thirdparty/market/cryptocompare/client_test.go | Deleted provider unit tests. |
| tests-unit-network/cryptocompare/cryptocompare_test.go | Deleted live network test. |
| services/wallet/service.go | Stop building CryptoCompare clients; drop statusProxyStageName arg. |
| services/wallet/api_impl_test.go | Update NewService call. |
| services/wallet/keycard_pairings_test.go | Update NewService call. |
| pkg/backend/node/status_node_services.go | Drop stage-name plumbing from wallet service creation. |
| pkg/backend/defaults.go | Stop copying StatusProxyMarket* request fields. |
| params/config.go | Remove StatusProxyMarket* fields from WalletConfig. |
| protocol/requests/create_account.go | Remove StatusProxyMarket* request fields. |
| internal/logutils/callog/status_request_log.go | Remove redaction entries for removed fields. |
| tests-functional/clients/status_backend.py | Stop setting market proxy credentials in test setup. |
| services/wallet/token/token.go | Update doc comments to mention only CoinGecko. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Jenkins Builds
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/10.34.x #7490 +/- ##
==================================================
Coverage ? 61.31%
==================================================
Files ? 850
Lines ? 118990
Branches ? 0
==================================================
Hits ? 72961
Misses ? 38565
Partials ? 7464
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saledjenic
approved these changes
Jun 4, 2026
Contributor
Author
|
will be merged together with #7492 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes status-im/status-app#20243