Skip to content

feat: add ndarray/base/eye#11070

Open
LoayAhmed304 wants to merge 7 commits intostdlib-js:developfrom
LoayAhmed304:feat/eye-base-ndarray
Open

feat: add ndarray/base/eye#11070
LoayAhmed304 wants to merge 7 commits intostdlib-js:developfrom
LoayAhmed304:feat/eye-base-ndarray

Conversation

@LoayAhmed304
Copy link
Contributor

@LoayAhmed304 LoayAhmed304 commented Mar 21, 2026


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: na
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request:

  • Implements the eye function for ndarrays, which creates a two-dimensional array with ones on a diagonal and zeros elsewhere.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 21, 2026

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/eye $\color{green}187/187$
$\color{green}+100.00%$
$\color{green}20/20$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}187/187$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@LoayAhmed304 LoayAhmed304 force-pushed the feat/eye-base-ndarray branch from 3743809 to e3c3225 Compare March 21, 2026 11:16
@LoayAhmed304 LoayAhmed304 changed the title feat: add initial implementation feat: add ndarray/base/eye Mar 21, 2026
@github-actions github-actions bot mentioned this pull request Mar 21, 2026
@LoayAhmed304 LoayAhmed304 force-pushed the feat/eye-base-ndarray branch from e5b3249 to bfc255e Compare March 23, 2026 00:41
@LoayAhmed304 LoayAhmed304 force-pushed the feat/eye-base-ndarray branch 4 times, most recently from 7ff14af to c18245d Compare March 23, 2026 02:02
@LoayAhmed304 LoayAhmed304 marked this pull request as ready for review March 23, 2026 02:06
@kgryte kgryte added Feature Issue or pull request for adding a new feature. difficulty: 3 Likely to be challenging but manageable. labels Mar 24, 2026
@LoayAhmed304 LoayAhmed304 force-pushed the feat/eye-base-ndarray branch from 0e2163e to 1edd03f Compare March 24, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 3 Likely to be challenging but manageable. Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants