chore: fix JavaScript lint errors (issue #7024) #7037
+7
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
First-time Contributor
stdlib-bot
removed
the
First-time Contributor
…e-nth-factorial/lib/index.js
kgryte
reviewed
May 21, 2025
| @@ -17,14 +17,16 @@ | |||
| */ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| // eslint-disable-next-line no-warning-comments | |||
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line no-warning-comments |
There was a problem hiding this comment.
We want to flag warning comments such as this. Disabling prevents us from doing so. That also applies below. Please just focus on updating the loop.
kgryte
reviewed
May 21, 2025
Comment on lines
+179
to
+180
| for ( var i = 0; i < arguments.length; i++ ) { | ||
| args.push(arguments[i]); |
There was a problem hiding this comment.
Neither of these lines follows project conventions.
kgryte
added
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7024
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers