Skip to content

Refactor Browser Path Handling#55

Open
Emmanuel-Melon wants to merge 1 commit intosteel-dev:mainfrom
Emmanuel-Melon:feat/browser-path-validation
Open

Refactor Browser Path Handling#55
Emmanuel-Melon wants to merge 1 commit intosteel-dev:mainfrom
Emmanuel-Melon:feat/browser-path-validation

Conversation

@Emmanuel-Melon
Copy link
Contributor

What's Changed:

  • Introduced getBrowserExecutablePath as unified path resolver
  • Added BrowserType enum and BrowserPaths interface for type safety
  • Deprecated getChromeExecutablePath in favor of new generic resolver
  • Maintained backward compatibility with Chrome-specific implementation
  • Added platform validation checks

Why This Matters:

  • 🏗 Foundation for future Firefox/Edge browser integrations
  • 📁 Cleaner path management with centralized configuration
  • 🔍 Better error detection for missing executables

Pending Tests

  • Verify Chrome path resolution on Windows/macOS/Linux
  • Ensure backward compatibility with existing implementations

@Emmanuel-Melon Emmanuel-Melon marked this pull request as ready for review February 4, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant