fix: accept string-form version in posting_json_metadata

[ety001]

Problem

The version field in posting_json_metadata → profile is serialized inconsistently across Steem clients:

Source	version value	Type
Official condenser (Settings.jsx:169)	2	JSON number
Some third-party clients	"2"	JSON string

The strict equality check at hive/utils/account.py:14 only accepted the numeric form:

assert 'version' in prof and prof['version'] == 2

A string "2" fails "2" == 2 in Python → assertion fails → falls through to json_metadata fallback → if that is also empty/invalid → prof = {} → all profile fields (profile_image, cover_image, name, about, etc.) are stored as empty strings in hive_accounts.

Impact

Since safe_profile_metadata() runs during indexing and the result is persisted to the hive_accounts DB table, affected accounts have empty profile data in the database. The condenser frontend calls bridge.get_profile, reads these empty strings, and:

• Avatar hidden: Userpic component hideIfDefault logic sees empty profile_image → hides the avatar entirely
• Banner hidden: UserProfileHeader sees empty cover_image → no banner background rendered

Real-world example: user bijoy1 (version "2", empty json_metadata) — both avatar and banner invisible on steemit.com.

Note on data flow

This function executes once during indexer account sync. The parsed result is written to the hive_accounts table (columns profile_image, cover_image, etc.). After this fix is deployed, affected accounts will be corrected on their next account refresh cycle.

Fix

Change prof['version'] == 2 to prof['version'] in (2, '2') — accepts both numeric and string forms.

Added a detailed comment explaining the inconsistency and a TODO to standardize on a single canonical type (JSON number) when a new version is introduced.

Test

Added test_string_version_account covering the string-form version case. All 3 tests pass:

tests/utils/test_utils_account.py::test_valid_account PASSED
tests/utils/test_utils_account.py::test_string_version_account PASSED
tests/utils/test_utils_account.py::test_invalid_account PASSED