tpm2: use BN_BIT2 to determine RADIX_BITS#537
Merged
Conversation
With LibreSSL 4.2.0 the THIRTY_TWO_BIT and SIXTY_FOUR_BIT_LONG defines were removed, but BN_BITS2 has the correct value for RADIX_BITS. Signed-off-by: orbea <orbea@riseup.net>
Owner
|
Looks good to me. OpenSSL's bn.h from v1.1.0 to v3.6.0 should all work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I am not certain I am doing this correctly, please review. All of the tests pass on my system at least.
With LibreSSL
4.2.0theTHIRTY_TWO_BITandSIXTY_FOUR_BIT_LONGdefines were removed, butBN_BITS2has the correct value forRADIX_BITS.