Remove deprecated activerecord-trilogy-adapter from Appraisals - #752
Merged
Conversation
kbrock
force-pushed
the
drop_trilogy_adapter_gem
branch
2 times, most recently
from
March 31, 2026 18:34
1bf8977 to
d93504c
Compare
Trilogy adapter is built into Rails 7.1+. The activerecord-trilogy-adapter gem is deprecated and not needed — trilogy support only targets Rails 7.1+. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kbrock
force-pushed
the
drop_trilogy_adapter_gem
branch
from
March 31, 2026 21:22
d93504c to
cc46697
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #751. The
activerecord-trilogy-adaptergem is deprecated — trilogy adapter is built into Rails 7.1+. Since we only support trilogy on 7.1+, the gem is not needed.Before
Appraisals adds
activerecord-trilogy-adapterfor Rails < 7.1.After
Removed. Trilogy support targets Rails 7.1+ only.
The activerecord-trilogy-adapter has been archived.
So no reason to add support to EOL ruby with an EOL driver.
Just stick with the current stack.
Type of Change
Checklist
bundle exec rake test)How Has This Been Tested?
bundle exec rake test— 250 runs, 0 failuresDB=trilogy bundle exec rake test— 250 runs, 0 failures (Rails 7.2)