Stop assigning validation_context in sane_ancestor_ids? - #769
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rails main removed the private
validation_context=writer (rails/rails#58220), sosane_ancestor_ids?now raisesNoMethodErrorwhenever a node with descendants is moved orcheck_ancestry_integrity!runs. The context juggling was only there to give a cleaner error and nothing in the method reads it (the validators are invoked directly throughvalidate_each), so this drops it rather than reaching into the new internalValidationContextobject. Fixes #766Before
child.update!(parent: nil)on Rails main:NoMethodError: undefined method 'validation_context=' for an instance of NodeAfter
Move and integrity check work on Rails main, behavior unchanged on released Rails.
Type of Change
Checklist
bundle exec rake test)How Has This Been Tested?
DB=sqlite3 bundle exec rake teston the default Gemfile, 258 runs 0 failures. The existingsane_ancestor_ids?tests in the materialized path suites cover the method; Rails main is not in the appraisal matrix so the failing path itself is not exercised in CI.