Analyze 8-K tool bug fix #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducing the bug with the following query:
The
analyze_8ktool call in its current form fails with the errorThis is because the edgartools package returns the date_of_report property as a string. So it needs to parsed back into a datetime object with
datetime.strptimebefore converting to the desired isoformat.The tool will also subsequently fail with this error at a later step
Again this depends on the implementation of the
PressReleasesclass in edgartools but a quick fix was to wrap it withlist(). Also noticed thatPressReleasedoes not have a title property or attribute so I removed that.With these proposed changes, the
analyze_8ktool call works as expected.