Skip to content

docs(changelog): record #384 Google custom endpoint fix - #385

Merged
steipete merged 1 commit into
mainfrom
chore/changelog-0.21.10-384
Aug 10, 2026
Merged

docs(changelog): record #384 Google custom endpoint fix#385
steipete merged 1 commit into
mainfrom
chore/changelog-0.21.10-384

Conversation

@steipete

Copy link
Copy Markdown
Owner

Maintainer-side changelog entry for #384, which landed as b1b974b. Contributors do not edit CHANGELOG.md in this repo, so the entry and the credit to @alfozan are added on merge.

@clawsweeper

clawsweeper Bot commented Aug 10, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@steipete
steipete merged commit fd5350f into main Aug 10, 2026
4 checks passed
@steipete
steipete deleted the chore/changelog-0.21.10-384 branch August 10, 2026 01:47
@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Aug 10, 2026
@clawsweeper

clawsweeper Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed August 9, 2026, 9:46 PM ET / August 10, 2026, 01:46 UTC.

ClawSweeper review

What this changes

Adds an unreleased changelog entry for the merged fix that bypasses Gemini Developer API model discovery when a custom Google endpoint is configured.

Merge readiness

⚠️ Ready for maintainer review - 1 item remains

Keep open for normal maintainer merge: this owner-authored, changelog-only PR accurately records the merged Google endpoint fix and follows the repository’s release-note workflow.

Priority: P3
Reviewed head: 23b4b9fe0f0d54b95a9df4ab3b97ab8c9668828a

Review scores

Measure Result What it means
Overall readiness 🦞 diamond lobster (5/6) A focused and accurate release-note patch for a merged, regression-tested fix.
Proof confidence 🌊 off-meta tidepool Not applicable: This maintainer-authored release-documentation PR does not change runtime behavior requiring new proof.
Patch quality 🦞 diamond lobster (5/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: This maintainer-authored release-documentation PR does not change runtime behavior requiring new proof.
Evidence reviewed 5 items Focused patch: The PR adds one Fixes subsection and one entry under the unreleased version; it changes no runtime code.
Implementation matches entry: Current main bypasses Developer API discovery for custom Google base URLs, while retaining discovery for the normal Developer API endpoint.
Regression coverage: The merged fix includes coverage for custom endpoints and the default endpoint variants.
Findings None None.
Security None None.

How this fits together

The CLI resolves a configured AI model before sending content for summarization. This PR changes only the release-facing record of the already merged Google provider-routing fix.

flowchart LR
  A[Google endpoint configuration] --> B[Model resolution]
  B --> C[Summary inference]
  D[Merged provider fix] --> E[Unreleased changelog]
  E --> F[Release notes]
Loading

Before merge

  • Complete next step (P2) - No repair work is needed; this focused maintainer-authored release note only needs ordinary merge handling.
Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Release-note scope 4 added, 0 removed; 1 file affected The branch is limited to the release-owned changelog and has no runtime effect.

Root-cause cluster

Relationship: partial_overlap
Canonical: #384
Summary: This PR is release documentation for the already merged implementation in the canonical related PR.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Technical review

Best possible solution:

Merge this concise unreleased note alongside the existing implementation so the next release documents the custom Google endpoint behavior and contributor credit.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this PR only records an already merged runtime fix in release notes.

Is this the best way to solve the issue?

Yes: a maintainer-side unreleased changelog entry is the repository’s documented way to credit and describe landed contributor fixes.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against b1b974bb6631.

Labels

Label changes:

  • add P3: This is a small release-documentation update with no runtime behavior change.
  • add rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🌊 off-meta tidepool and patch quality is 🦞 diamond lobster.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This maintainer-authored release-documentation PR does not change runtime behavior requiring new proof.

Label justifications:

  • P3: This is a small release-documentation update with no runtime behavior change.
  • rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🌊 off-meta tidepool and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This maintainer-authored release-documentation PR does not change runtime behavior requiring new proof.

Evidence

What I checked:

  • Focused patch: The PR adds one Fixes subsection and one entry under the unreleased version; it changes no runtime code. (CHANGELOG.md:3, 23b4b9fe0f0d)
  • Implementation matches entry: Current main bypasses Developer API discovery for custom Google base URLs, while retaining discovery for the normal Developer API endpoint. (src/engine/model-call.ts:39, b1b974bb6631)
  • Regression coverage: The merged fix includes coverage for custom endpoints and the default endpoint variants. (tests/engine.model-call.test.ts:6, b1b974bb6631)
  • History and release position: The documented fix is commit b1b974b, merged after v0.21.9; it is on current main and is correctly listed under 0.21.10 Unreleased. (CHANGELOG.md:3, b1b974bb6631)
  • Repository contribution policy: The contribution guide reserves CHANGELOG.md edits for maintainers when landing contributor work; the PR body identifies this as that maintainer-side entry. (CONTRIBUTING.md:73, b1b974bb6631)

Likely related people:

  • alfozan: Authored the merged Google custom-endpoint implementation that this release note describes. (role: introduced provider fix; confidence: high; commits: b1b974bb6631; files: src/engine/model-call.ts, tests/engine.model-call.test.ts)
  • steipete: Authored this maintainer-side changelog entry and the surrounding release-development history. (role: release-note author; confidence: high; commits: 23b4b9fe0f0d, 7d7e3dacf4d8; files: CHANGELOG.md, CONTRIBUTING.md)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant