chore: refresh dependencies and security fixes - #386
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs maintainer review before merge. Reviewed August 10, 2026, 9:48 AM ET / 13:48 UTC. ClawSweeper reviewWhat this changesRefreshes four direct package versions and several patched transitive resolutions, adds a daemon URL-fetch SSRF regression test, and reformats one existing test helper. Merge readinessKeep open: this owner-authored, bounded security-maintenance PR has no actionable correctness finding; two supplied CI runs were still in progress at review time. Priority: P2 Review scores
Verification
How this fits togetherThe daemon accepts a page URL for extraction, validates it through the shared network guard, then performs a DNS-pinned fetch. The CLI and Chrome extension consume the workspace dependency manifests and lockfile updated by this PR. flowchart LR
A[Daemon summarize request] --> B[Page URL]
B --> C[Network safety guard]
C --> D{Public HTTP target?}
D -->|No| E[Reject request]
D -->|Yes| F[DNS-pinned fetch]
F --> G[Content extraction]
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Retain the narrow dependency refresh and SSRF regression, then merge after the remaining exact-head checks complete successfully. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR adds regression coverage rather than reporting a user-facing failure; the added cases are source-visible and targeted. Is this the best way to solve the issue? Yes: preserving the native URL parsing and shared guard while adding a focused no-fetch assertion is the narrowest maintainable protection for these normalized URL forms. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 9fdac4dd6d6e. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Summary
Security analysis
The fast-uri advisory does not sit on summarize's runtime fetch path. It is a dev-only dependency of web-ext via addons-linter and Ajv. The SSRF guard uses Node's native WHATWG URL for both host classification and the normalized fetch target, so it does not have the fast-uri/native URL parser split described by GHSA-7p8r-x3mc-p8w7. The added regression proves private backslash-authority targets are rejected before fetch.
The two remaining high advisories are both in image-size 2.0.2, for which no patched version exists. image-size is also dev-only under web-ext/addons-linter. It sizes only packaged extension manifest icons and theme images during lint; summarize does not pass downloaded or user-supplied content into it. The checked-in extension has no ICNS, JXL, HEIF, or HEIC inputs, and Firefox lint completed against the built artifact. The best upstream fix is for addons-linter to replace image-size or validate supported magic before calling it; an override cannot repair the vulnerable parser.
Verification