Skip to content

chore: refresh policy-eligible dependencies - #388

Merged
steipete merged 1 commit into
mainfrom
chore/dependency-refresh-2026-08-13
Aug 13, 2026
Merged

chore: refresh policy-eligible dependencies#388
steipete merged 1 commit into
mainfrom
chore/dependency-refresh-2026-08-13

Conversation

@steipete

Copy link
Copy Markdown
Owner

Summary

  • upgrade the repository package manager from pnpm 10.34.5 to policy-eligible pnpm 11.20.0
  • upgrade web-ext from 10.5.0 to 10.6.0 and refresh its eligible transitive graph
  • explicitly approve the three dependency lifecycle scripts required by pnpm 11; the Google hook is a verified no-op, while onnxruntime-node and protobufjs retain their prior install behavior

Cooldown holds

The seven-day minimum release age still holds pnpm 11.21.0, oxfmt 0.63.0, oxlint 1.78.0, tsx 4.23.12, esbuild 0.28.2, and oxc-parser 0.144.0. The latter five were published August 8–10; pnpm 11.21.0 was published August 9. tsx and esbuild also remain excluded from the relevant Vite/WXT optional-peer paths by workspace overrides. Node 26 typings remain held to the minimum supported Node 24 contract.

Verification

  • pnpm install --frozen-lockfile — passed with pnpm 11.20.0 and supply-chain verification of 793 lock entries
  • pnpm -s check — 556 test files passed, 29 skipped; 3,015 tests passed, 43 skipped; 91.76% statement coverage
  • pnpm -s build and node dist/cli.js --version — passed; CLI reported 0.21.11
  • pnpm -C apps/chrome-extension test:chrome — native/browser-slides subset 3/3 passed; full suite 112 passed, 7 intentionally skipped
  • pnpm -C apps/chrome-extension test:firefox:lint — 0 errors, 0 notices, 24 existing compatibility/security warnings
  • autoreview — clean, no accepted/actionable findings

Audit

pnpm audit --audit-level high reports the two known image-size 2.0.2 denial-of-service advisories. No upstream 2.0.3 release exists. Both findings remain deliberately visible and are remediated by the checked-in pnpm patch plus the timeout-isolated regression test in tests/dependency.image-size-security.test.ts.

@clawsweeper

clawsweeper Bot commented Aug 13, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@clawsweeper clawsweeper Bot added merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Aug 13, 2026
@clawsweeper

clawsweeper Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed August 13, 2026, 6:35 AM ET / 10:35 UTC.

ClawSweeper review

What this changes

This PR upgrades pnpm and web-ext, refreshes the lockfile, and permits three lifecycle scripts required by pnpm 11.

Merge readiness

⚠️ Ready for maintainer review - 2 items remain

Keep open for explicit owner approval: the focused pnpm 11 migration intentionally changes install-time third-party script permissions. Likely related people: steipete (high confidence).

Priority: P3
Reviewed head: b40fb29cdc977bbb396acea4c2e2befae5f79dfd
Owner decision: Required. See Decision needed.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) Focused policy and lockfile update with stated clean-install, build, core, and extension validation, pending explicit supply-chain approval.
Proof confidence 🌊 off-meta tidepool Not applicable: This owner-authored maintenance PR is not subject to the external-contributor proof gate; its body records clean-install, build, core-check, and extension validation.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: This owner-authored maintenance PR is not subject to the external-contributor proof gate; its body records clean-install, build, core-check, and extension validation.
Evidence reviewed 4 items Lifecycle policy change: The PR adds pnpm 11 allowBuilds entries only for @google/genai, onnxruntime-node, and protobufjs.
Security patch retained: The migrated lockfile continues to record the image-size patch hash and patched snapshot.
Policy and patch provenance: Current-main blame ties the existing image-size mitigation to the v0.21.11 release commit by Peter Steinberger; the proposed permissions date to this PR commit.
Findings None None.
Security None None.

How this fits together

The workspace package manager resolves dependencies for the CLI, core library, and Chrome extension. Its workspace policy and lockfile control reproducible installs, install-time scripts, and extension tooling.

flowchart LR
  A[Workspace manifests] --> B[Package manager policy]
  B --> C[Dependency resolution]
  C --> D[Lockfile]
  D --> E[CLI and core build]
  D --> F[Chrome extension tooling]
  B --> G[Allowed lifecycle scripts]
Loading

Decision needed

Question Recommendation
Should this repository permit lifecycle scripts from @google/genai, onnxruntime-node, and protobufjs as part of the pnpm 11 migration? Approve the scoped pnpm 11 policy: Merge with the three explicit approvals, preserving the existing locked patch and validation coverage.

Why: The patch intentionally changes third-party install-time execution policy, which requires repository-owner judgment.

Before merge

  • Resolve merge risk (P1) - A clean install will newly execute lifecycle scripts from three transitive packages; this intentional supply-chain policy change requires owner approval before merge.
Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Dependency policy surface 5 files affected; 107 additions, 120 deletions Application source is unchanged while package resolution, extension tooling, and install-script policy change together.

Merge-risk options

Maintainer options:

  1. Confirm the intended install-time boundary (recommended)
    Approve the three explicit pnpm build permissions only after confirming their scripts are required for supported builds and extension tooling.
  2. Defer the package-manager migration
    Keep pnpm 10 until the repository owner is comfortable accepting the new lifecycle-script policy.

Technical review

Best possible solution:

Merge only after explicitly accepting the three narrowly scoped lifecycle permissions while retaining the image-size patch and its regression coverage.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this is dependency-maintenance work rather than a report of broken runtime behavior.

Is this the best way to solve the issue?

Yes, conditionally: the lockfile migration preserves the existing image-size patch, and a narrow allowlist is preferable to unrestricted lifecycle scripts.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 1cc9e1866e8a.

Labels

Label changes:

  • add P3: This is routine dependency and build-policy maintenance with no reported user-facing regression.
  • add merge-risk: 🚨 compatibility: The pnpm major-version and lockfile transition can affect clean installs and Chrome-extension tooling on developer environments.
  • add merge-risk: 🚨 security-boundary: The workspace policy newly allows three third-party lifecycle scripts to execute during installation.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This owner-authored maintenance PR is not subject to the external-contributor proof gate; its body records clean-install, build, core-check, and extension validation.

Label justifications:

  • P3: This is routine dependency and build-policy maintenance with no reported user-facing regression.
  • merge-risk: 🚨 compatibility: The pnpm major-version and lockfile transition can affect clean installs and Chrome-extension tooling on developer environments.
  • merge-risk: 🚨 security-boundary: The workspace policy newly allows three third-party lifecycle scripts to execute during installation.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This owner-authored maintenance PR is not subject to the external-contributor proof gate; its body records clean-install, build, core-check, and extension validation.

Evidence

What I checked:

  • Lifecycle policy change: The PR adds pnpm 11 allowBuilds entries only for @google/genai, onnxruntime-node, and protobufjs. (pnpm-workspace.yaml:6, b40fb29cdc97)
  • Security patch retained: The migrated lockfile continues to record the image-size patch hash and patched snapshot. (pnpm-lock.yaml:20, b40fb29cdc97)
  • Policy and patch provenance: Current-main blame ties the existing image-size mitigation to the v0.21.11 release commit by Peter Steinberger; the proposed permissions date to this PR commit. (pnpm-workspace.yaml:32, 1dcbff752de7)
  • Current-main and release status: The proposed commit is not contained by a tag or current local branch, while the prior patch-retention commit is contained by v0.21.11. (b40fb29cdc97)

Likely related people:

  • steipete: Current-main history and this proposed update identify Peter Steinberger as the primary contributor for workspace dependency policy and the image-size mitigation. (role: recent dependency-policy contributor; confidence: high; commits: 1dcbff752de7, b40fb29cdc97; files: pnpm-workspace.yaml, pnpm-lock.yaml, patches/image-size@2.0.2.patch)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Record approval of the three lifecycle-script permissions before merging.

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@steipete
steipete merged commit c78ac23 into main Aug 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant