chore: refresh policy-eligible dependencies - #388
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs maintainer review before merge. Reviewed August 13, 2026, 6:35 AM ET / 10:35 UTC. ClawSweeper reviewWhat this changesThis PR upgrades pnpm and web-ext, refreshes the lockfile, and permits three lifecycle scripts required by pnpm 11. Merge readinessKeep open for explicit owner approval: the focused pnpm 11 migration intentionally changes install-time third-party script permissions. Likely related people: steipete (high confidence). Priority: P3 Review scores
Verification
How this fits togetherThe workspace package manager resolves dependencies for the CLI, core library, and Chrome extension. Its workspace policy and lockfile control reproducible installs, install-time scripts, and extension tooling. flowchart LR
A[Workspace manifests] --> B[Package manager policy]
B --> C[Dependency resolution]
C --> D[Lockfile]
D --> E[CLI and core build]
D --> F[Chrome extension tooling]
B --> G[Allowed lifecycle scripts]
Decision needed
Why: The patch intentionally changes third-party install-time execution policy, which requires repository-owner judgment. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Merge only after explicitly accepting the three narrowly scoped lifecycle permissions while retaining the image-size patch and its regression coverage. Do we have a high-confidence way to reproduce the issue? Not applicable: this is dependency-maintenance work rather than a report of broken runtime behavior. Is this the best way to solve the issue? Yes, conditionally: the lockfile migration preserves the existing image-size patch, and a narrow allowlist is preferable to unrestricted lifecycle scripts. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 1cc9e1866e8a. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Summary
Cooldown holds
The seven-day minimum release age still holds pnpm 11.21.0, oxfmt 0.63.0, oxlint 1.78.0, tsx 4.23.12, esbuild 0.28.2, and oxc-parser 0.144.0. The latter five were published August 8–10; pnpm 11.21.0 was published August 9. tsx and esbuild also remain excluded from the relevant Vite/WXT optional-peer paths by workspace overrides. Node 26 typings remain held to the minimum supported Node 24 contract.
Verification
pnpm install --frozen-lockfile— passed with pnpm 11.20.0 and supply-chain verification of 793 lock entriespnpm -s check— 556 test files passed, 29 skipped; 3,015 tests passed, 43 skipped; 91.76% statement coveragepnpm -s buildandnode dist/cli.js --version— passed; CLI reported 0.21.11pnpm -C apps/chrome-extension test:chrome— native/browser-slides subset 3/3 passed; full suite 112 passed, 7 intentionally skippedpnpm -C apps/chrome-extension test:firefox:lint— 0 errors, 0 notices, 24 existing compatibility/security warningsAudit
pnpm audit --audit-level highreports the two known image-size 2.0.2 denial-of-service advisories. No upstream 2.0.3 release exists. Both findings remain deliberately visible and are remediated by the checked-in pnpm patch plus the timeout-isolated regression test intests/dependency.image-size-security.test.ts.