feat: add Turkish localization - #398
Open
husodrn46 wants to merge 6 commits into
Open
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
clawsweeper
Bot
added
P3
|
Codex review: blocked before merge. Reviewed September 4, 2026, 9:28 PM ET / September 5, 2026, 01:28 UTC. ClawSweeper reviewWhat this changesAdds Turkish CLI help, progress, and status text plus selectable extension interface localization, independently of the generated summary language. Merge readiness⛔ Blocked before merge - 3 items remain The three previous blockers are repaired, and the interface localization remains distinct from current main. One additional display-integrity defect remains; acceptance of the broader feature is also explicitly pending. Priority: P2 Review scores
Verification
How this fits togetherSummarize’s CLI and browser extension present controls and progress around content extraction and summarization. The new locale layer translates interface text using CLI arguments or saved browser preferences, while summary language is configured separately. flowchart TD
A[CLI arguments and environment] --> C[Interface locale selection]
B[Saved extension preferences] --> C
C --> D[CLI labels and extension controls]
E[Summary language setting] --> F[Generated summary]
G[User text and diagnostic data] --> H[Unchanged content display]
F --> H
Decision needed
Why: The repository owner explicitly left broader feature acceptance pending; contributing compatibility repairs does not establish acceptance of the permanent localization surface. Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Localize application-owned interface text while preserving user prompts, source titles, diagnostics, legacy preferences, and the independent summary-language setting. Do we have a high-confidence way to reproduce the issue? Yes, from PR-head source: select Turkish and queue 'Try again' while a response is streaming; the preview and tooltip translate while the queued prompt remains English. This was not executed locally and is not claimed as a current-main failure. Is this the best way to solve the issue? Not fully: separating interface language from summary language and preserving legacy English are appropriate, but the body-wide translator still needs explicit exclusions for queued prompts and source titles. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 589c6c2876f0. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (11 earlier review cycles; latest 8 shown)
|
Author
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
Author
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
clawsweeper
Bot
added
rating: 🧂 unranked krab
Author
|
@clawsweeper re-review Updated the PR with inspectable evidence: real headed Chromium regression, Turkish CLI help output, local slide/parser fixture tests, Chrome/Firefox builds, and a privacy-reviewed screenshot. The screenshot path is now |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
clawsweeper
Bot
added
P1
clawsweeper
Bot
added
rating: 🧂 unranked krab
Keep existing profiles in English, apply locale changes to open panels, and exclude diagnostic and process payloads from DOM translation. Preserve CLI arguments after -- and protect interpolated values explicitly. Add regressions and move synthetic proof from source to PR attachments. Co-authored-by: Hüseyin Durna <76519526+husodrn46@users.noreply.github.com>
Owner
|
Pushed the compatibility repairs in 90cc057, preserving @husodrn46's contributor credit. Existing profiles keep English, locale changes reach open panels, and diagnostics/process values remain untouched. CLI rendering now preserves interpolated paths and identifiers, and slide arguments after Verification: All jobs in CI run 33935380465 passed. This PR remains open for acceptance of the broader localization feature; no merge or release was performed. |
clawsweeper
Bot
added
P2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Turkish interface localization for CLI help, progress, and status, plus extension Options and the side panel.
--languagecontinues to control generated summary language independently.The maintainer follow-up repairs compatibility issues across extension and CLI output:
uiLocaleretain English. Fresh installations retain Automatic; users can explicitly select English, Turkish, or Automatic.--reach the parser intact, even when a filename resembles a locale option.Generated proof belongs in test output and the PR, so the checked-in screenshot and one-off proof document were moved out of the source tree. Contributor credit remains with @husodrn46.
Verification
pnpm run buildandpnpm run checkpass: 558 test files, 3,057 tests, 43 skipped; line coverage 94.13%, branch coverage 85.08%.--, retained theCopy faileddirectory name, and printed Turkish labels.Before and after
Existing profile on a Turkish browser: the original silently switches to Turkish; the repaired version preserves English.
Turkish diagnostic view: the original changes the raw
Error:prefix toHata:; the repaired version preserves the payload and severity while translating the UI controls.Maintainer decision
The compatibility repairs are ready for review. Acceptance of the broader Turkish localization feature remains pending; the conservative upgrade behavior above avoids silently changing existing users' interface language.