refactor(extension): remove redundant panel state dispatch

[steipete]

What changed

Delete the sidepanel action union, pure reducer, mutable wrapper store, optional dispatch dependencies, and repeated fallback dispatchers. They were translating plain state updates into action objects, constructing immutable root copies, then copying those copies straight back into one mutable root.

PanelState is now the single data owner. Scalars update directly; a typed nested-slice patch preserves captured snapshots; named transitions retain coupled phase/error, attach/restore, and reset behavior. No compatibility dispatcher remains.

This removes 463 production lines and 520 lines overall. Navigation, pending runs, chat, settings hydration, retained summaries, and omitted-versus-null slide restoration retain their behavior.

Proof

• 372 sidepanel unit tests pass, including explicit root identity and nested snapshot checks.
• Build and the full project gate pass: formatting, lint, core/CLI type checks, and 3,070 tests (43 skipped).
• 28 Chromium scenarios pass: core UI, chat, cache/navigation, slide restoration, and synthetic rendered-state proof.
• Independent Codex review: no actionable P0–P2 findings.
• Synthetic before/after screenshots are byte-identical. Hosted CI run 33938440683 passed on this exact head: Node 24, Chromium E2E, Firefox smoke, and security checks.

A separate standalone extension tsc invocation reports the extension's extensionless-import/NodeNext configuration errors; that configuration is unchanged. The supported extension build and browser tests above pass.

Before and after

Both synthetic captures have the same SHA-256, so the same uploaded image represents their identical content.

Before:

After:

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: needs maintainer review before merge. Reviewed September 4, 2026, 10:45 PM ET / September 5, 2026, 02:45 UTC.

ClawSweeper review

What this changes

Simplifies browser-extension state updates by removing action-dispatch plumbing and updating summary, chat, navigation, slide handling, tests, and architecture documentation.

Merge readiness

✅ Ready for maintainer review

Keep open: the cleanup is not present on the reviewed main or captured latest release, and no actionable correctness findings were found. Owner authorship and the repository’s conservative review policy also preclude cleanup closure.

Priority: P3
Reviewed head: 32c37b74379303f3c53ac32d68b636ea14c2d8d5

Review scores

Measure	Result	What it means
Overall readiness	🐚 platinum hermit (4/6)	A focused, net-reducing refactor with preserved state invariants, relevant regression coverage, and no actionable review findings.
Proof confidence	🌊 off-meta tidepool	Not applicable: The contributor proof gate does not apply to this owner-authored internal refactor, and no material authority change triggers an exception. The captured body reports Chromium navigation, chat, and restoration coverage; its synthetic image is not treated as independent proof of every lifecycle path.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Verification

Check	Result	Evidence
Real behavior	Not applicable	Not applicable: The contributor proof gate does not apply to this owner-authored internal refactor, and no material authority change triggers an exception. The captured body reports Chromium navigation, chat, and restoration coverage; its synthetic image is not treated as independent proof of every lifecycle path.
Evidence reviewed	9 items	Repository policy inspected: Read the complete root AGENTS.md and CONTRIBUTING.md. No nested AGENTS.md files or maintainer-note files were found in the applicable trees. Applied the internal package boundary and supported Chromium validation guidance; no build, test, or repository-mutating helper was executed. Introduced patch and merge identity: The checkout matches the pinned original head. Raw test-merge records contain the pinned main parent followed by the exact PR head, and the test-merge tree matches the head tree. Review therefore used the introduced main-to-head changes, not unrelated endpoint drift. Still distinct from main and release: Reviewed main and captured latest release v0.21.11 contain the identical panel-state-store blob, 1ab7760b63c83ac219ecfe612d8c607710151bd4, with the action union, reducer, and mutable dispatch wrapper still present. The release tag resolves to 1dcbff7. No superseding item was established; the attempted live canonical search could not connect.
Findings	None	None.
Security	None	None.

How this fits together

The browser extension’s sidepanel receives user actions, background messages, and summary or slide results. Its shared state coordinates rendering, chat, active-tab navigation, and restoration of cached results.

flowchart TD
  A[User actions] --> D[Sidepanel state]
  B[Background messages] --> D
  C[Summary and slide results] --> D
  D --> E[Lifecycle transitions]
  E --> F[Summary chat and slide views]
  E --> G[Cache snapshots and restoration]
  G --> D

Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

Metric	Value	Why it matters
Production and test LOC	Production −463 (+412/−875); tests −60 (+310/−370)	The reduction removes dispatch scaffolding while retaining direct state and lifecycle assertions.

Technical review

Best possible solution:

Maintain one panel-owned state object with snapshot-preserving nested updates and explicit coupled lifecycle transitions, without changing persisted settings or cache formats.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this PR proposes an internal refactor rather than a reported failure, and source comparison found no concrete introduced regression.

Is this the best way to solve the issue?

Yes: the removed dispatcher only translated actions into assignments on the same mutable root; direct updates and named transitions remove that indirection while preserving nested snapshots and lifecycle rules.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 589c6c2876f0.

Labels

Label justifications:

• P3: This is internal maintenance with no intended user-visible behavior change or demonstrated urgent regression.
• rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The contributor proof gate does not apply to this owner-authored internal refactor, and no material authority change triggers an exception. The captured body reports Chromium navigation, chat, and restoration coverage; its synthetic image is not treated as independent proof of every lifecycle path.

Evidence

What I checked:

• Repository policy inspected: Read the complete root AGENTS.md and CONTRIBUTING.md. No nested AGENTS.md files or maintainer-note files were found in the applicable trees. Applied the internal package boundary and supported Chromium validation guidance; no build, test, or repository-mutating helper was executed. (AGENTS.md:1, 32c37b743793)
• Introduced patch and merge identity: The checkout matches the pinned original head. Raw test-merge records contain the pinned main parent followed by the exact PR head, and the test-merge tree matches the head tree. Review therefore used the introduced main-to-head changes, not unrelated endpoint drift. (e89b7d7a77b4)
• Still distinct from main and release: Reviewed main and captured latest release v0.21.11 contain the identical panel-state-store blob, 1ab7760b63c83ac219ecfe612d8c607710151bd4, with the action union, reducer, and mutable dispatch wrapper still present. The release tag resolves to 1dcbff7. No superseding item was established; the attempted live canonical search could not connect. (apps/chrome-extension/src/entrypoints/sidepanel/panel-state-store.ts:128, 589c6c2876f0)
• Lifecycle semantics preserved: Compared the former reducer cases with the replacement helpers and their callers. Nested updates still replace slices; pending-run maps retain copy-on-update behavior; phase/error coupling, attachment, omitted-versus-null slides, and conditional run resets preserve the previous assignments. (apps/chrome-extension/src/entrypoints/sidepanel/panel-state-store.ts:62, 32c37b743793)
• Compatibility and security boundaries unchanged: Settings hydration still overlays pending settings onto loaded values before applying controls. The patch does not change PanelState types, cache serialization, settings definitions, background-message contracts, workflows, dependencies, or package metadata. The replaced dispatcher performed state assignments, not authorization checks or additional side effects. (apps/chrome-extension/src/entrypoints/sidepanel/bootstrap-runtime.ts:48, 32c37b743793)
• Focused state regression coverage: The updated tests retain restoration and reset assertions and explicitly cover preserved root identity, unchanged captured navigation/chat slices, and phase/error recovery. Settings and runtime tests were adapted to observe the same state directly rather than an injected dispatcher. These tests were inspected, not executed during this read-only review. (tests/sidepanel.panel-state-store.test.ts:302, 32c37b743793)

Likely related people:

• steipete: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score	Internal tier	Crab rank	Meaning
6/6	S	🦀 challenger crab	Exceptional readiness
5/6	A	🦞 diamond lobster	Very strong readiness
4/6	B	🐚 platinum hermit	Good normal PR; ordinary maintainer review
3/6	C	🦐 gold shrimp	Useful, but confidence is limited
2/6	D	🦪 silver shellfish	Proof or implementation needs work
1/6	F	🧂 unranked krab	Not merge-ready
N/A	NA	🌊 off-meta tidepool	Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (2 earlier review cycles)

• reviewed 2026-09-05T02:17:50.857Z sha 32c37b7 :: needs maintainer review before merge. :: none
• reviewed 2026-09-05T02:30:20.613Z sha 32c37b7 :: needs maintainer review before merge. :: none