README: the CI push secret is BENCHMARKS_PUSH_TOKEN - #33
Merged
Merged
Conversation
The merged text still named the deploy-key plan; the workflow reads BENCHMARKS_PUSH_TOKEN and clones over HTTPS. Left deliberately vague on the token flavor until the credential story settles. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
There was a problem hiding this comment.
Pull request overview
Updates the documentation to match the current ingest/publish authentication method used by stellar-rpc’s CI when pushing benchmark results to this repository.
Changes:
- Replace the README’s outdated deploy-key wording with the current secret name used for CI pushes (
BENCHMARKS_PUSH_TOKEN). - Clarify that the CI push uses a write-capable token (without committing to a specific credential flavor), while keeping the “no AWS creds in this repo” explanation intact.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #32 — that squash merged before this fix landed on the branch. The merged README still describes the abandoned deploy-key plan; the workflow actually clones over HTTPS with the
BENCHMARKS_PUSH_TOKENsecret. Deliberately vague on the token flavor until the credential story settles (deploy keys are disabled on the org; fine-grained PATs are not enabled for it either).🤖 Generated with Claude Code