Fix clippy failure on main: drop unused soroban_sdk imports - #25
Merged
Conversation
The event-standardization change switched to fully-qualified soroban_sdk::symbol_short! / soroban_sdk::Symbol::new call sites, leaving the top-level symbol_short and Symbol imports unused. Under the CI's clippy -D warnings gate this fails the Format & lint job on main. Drop the now-unused imports; the fully-qualified call sites are unchanged.
Same fully-qualified-call cleanup as the other modules: governance emits events via soroban_sdk::symbol_short!(...), leaving the top-level symbol_short import unused and failing clippy -D warnings once the earlier unused imports were removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
main's CI is currently red: the Format & lint job fails atclippy --all-targets --all-features -- -D warnings. Build, test, and fuzz all pass — this is the only breakage, and it blocks every new PR from showing green.Cause
The recent event-standardization work moved event emission to fully-qualified call sites (
soroban_sdk::symbol_short!(...),soroban_sdk::Symbol::new(...)), leaving two now-unused imports:escrow_contract/src/lib.rs— unusedsymbol_short,Symbolsoroban/src/operator_rotation.rs— unusedsymbol_shortUnder
-D warnings,unused_importsis an error.Fix
Remove only those unused imports; the fully-qualified call sites are untouched, so behavior is unchanged. Minimal diff: 2 files, +2/-5. Restores green CI on
main.