feat(analytics): report signing for internal transactions and add swap flow stages

[JakeUrban]

What

This change makes signing countable.

Sends, swaps and trustline changes now report how signing ended. The record names one of three outcomes: a signature, a decline by the user, or a failure the user did not choose. Both kinds of transaction use the same three. Failure is new for transactions, so a signing fault previously went unrecorded.

Each flow reports every outcome at its own point. An approval reports once a signature exists. A failure reports when signing cannot produce one. A rejection reports when the user leaves the review without approving, by any route. An approval sets a latch as the review opens, so it is never counted as a rejection.

Collectible sends are out of scope, so they report nothing for signing.

Every signing event now names its origin, either a website or the wallet itself. Both origins carry the same properties. A single query therefore counts all signing, and the origin splits that count. The website identity resolves before signing, so a failed request stays attributable to the site that asked for it.

The swap flow gains its in-flight stage and its success stage. The send flow reports both. Swap reports neither, so nobody can follow a swap past its review sheet.

Seven screen names are deleted. Nothing reports them, and their screens no longer exist.

The schema version moves up. Consumers need to tell an old client from a new one.

Why

Only requests from websites report signing today. Every transaction the wallet composes itself reports nothing for the signing action. Approval rate and signing outcomes are therefore unmeasurable for those flows.

A stage event cannot replace this. Swap reports no in-flight stage and no success stage at all. A stage event also marks a point in the flow, not a decision. Two separate signals answer the two questions: the stage event reports where the user is, and the signing event reports what they chose.

This is the mobile half of a cross-platform change. stellar/freighter#3008 is the browser-extension half. The two were written together, so both clients report the same events with the same shape.

Known limitations

This is not a purely additive change. Existing signing events gain a property, seven screen names disappear, and the schema version moves up. Any dashboard that depends on those names, or on the previous schema version, needs attention.

This pull request mixes a cleanup with the feature. The seven unused screen names are unrelated to signing. They are included because they sit in the same place, and their removal only deletes lines. Ask, and they move to a separate pull request.

No device run. Verification is automated only. Nothing here changes the screen, so there is nothing to show. Both platforms deserve a manual pass before this leaves draft, because the new reports sit inside real signing paths.

One funnel stays open. The flow exits without reporting an outcome when the wallet locks itself during a confirmation. An in-flight stage then has no ending. This behaviour predates this change, and this pull request does not address it.

Collectible sends share the send screen names. Stage events cannot separate them, and they report no signing outcome at all. Both are out of scope here.

Checklist

PR structure

• This PR does not mix refactoring changes with feature changes (break it down into smaller PRs if not). — the deletion is a cleanup; see Known limitations.
• This PR has reasonably narrow scope (break it down into smaller PRs if not).
• This PR includes relevant before and after screenshots/videos highlighting these changes. — not applicable; nothing on screen changes.
• I took the time to review my own PR.

Testing

• These changes have been tested and confirmed to work as intended on Android.
• These changes have been tested and confirmed to work as intended on iOS.
• These changes have been tested and confirmed to work as intended on small iOS screens.
• These changes have been tested and confirmed to work as intended on small Android screens.
• I have tried to break these changes while extensively testing them.
• This PR adds tests for the new functionality or fixes.

Release

• This is not a breaking change. — see Known limitations.
• This PR updates existing JSDocs when applicable.
• This PR adds JSDocs to new functionalities.
• I've checked with the product team if we should add metrics to these changes.
• I've shared relevant before and after screenshots/videos highlighting these changes with the design team and they've approved the changes. — not applicable; nothing on screen changes.

Verification

Check	Result
Test suite	3260 pass, no failures
Type check	clean
Lint	clean
Format	clean

New tests cover each signing outcome, the origin on both kinds of transaction, the attribution of a failed website request, and the three swap stages surviving a rapid swap.

The pre-commit hook could not run here. The network policy blocks the package host it installs from. Its three steps ran directly instead: lint and format on the staged files, then the test suite, then the type check. All three passed, and the commit then skipped the hook.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Qkq7j6uvUMU1bBQdcuGX8Z

[github-actions]

iOS Simulator preview build is ready: https://github.com/stellar/freighter-mobile/releases/tag/untagged-f0da3e7f6ab25f94ca3f
Backend: V1 prod + V2 staging (no sandbox configured for @JakeUrban). SDF collaborators only — install instructions in the release description.

[github-actions]

Android Emulator preview APK is ready: https://github.com/stellar/freighter-mobile/releases/tag/untagged-4166d04c174106b6a317
Backend: V1 prod + V2 staging (no sandbox configured for @JakeUrban). SDF collaborators only — install instructions in the release description.

[Copilot]

Pull request overview

Adds unified signing-outcome analytics for wallet-originated transactions and swap processing/success stages.

Changes:

• Adds signing source and outcome events.
• Instruments send and swap signing paths.
• Adds swap processing/success telemetry and schema v4.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/services/analytics/types.ts	Adds signing source metadata.
src/services/analytics/transactions.ts	Adds internal signing helpers and source properties.
src/services/analytics/index.ts	Exposes new analytics helpers.
src/services/analytics/core.ts	Bumps schema version.
src/config/analyticsConfig.ts	Adds swap stages and transaction failure event.
src/components/screens/SwapScreen/screens/SwapProcessingScreen.tsx	Emits swap processing and success stages.
src/components/screens/SwapScreen/screens/SwapAmountScreen.tsx	Attempts to track review rejection.
src/components/screens/SwapScreen/hooks/useSwapTransaction.ts	Tracks signing success and failure.
src/components/screens/SendScreen/screens/TransactionAmountScreen.tsx	Tracks send signing outcomes.
__tests__/services/analytics/transactions.test.ts	Tests signing event payloads.
__tests__/services/analytics/core.test.ts	Updates schema assertions and swap throttling coverage.
__tests__/components/screens/SwapScreen/useSwapTransaction.test.ts	Updates analytics mocks.
__tests__/components/screens/SendScreen/screens/TransactionAmountScreen.test.tsx	Updates analytics mocks.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Suppressed comments (4)

Previously missed (2) — in code that hasn't changed since the last review.

tests/components/screens/SendScreen/screens/TransactionAmountScreen.test.tsx:66

• These new analytics methods are only stubbed, so the existing confirmation test still passes if approval/failure/rejection reporting is removed or misclassified. Add assertions to the successful-sign and pre-submit-failure cases, and exercise onDismiss both with and without the approval latch.
  tests/components/screens/SwapScreen/useSwapTransaction.test.ts:114
• The new signing calls are mocked but never asserted. The existing null-signature and successful-swap cases should verify trackInternalSignedTransactionError and trackInternalSignedTransaction respectively (and that the opposite event is absent), otherwise this new instrumentation can regress while the suite remains green.

src/hooks/useManageTokens.ts:346

• The removal path has the same gap as addition: a thrown signing error skips this success call and reaches the generic token-management catch without emitting signing.transaction_failed. Report the caught signing error locally, then rethrow for the existing failure behavior.

        // A trustline change is a wallet-composed transaction, so it reports
        // its signing outcome like a send or a swap does.
        analytics.trackInternalSignedTransaction();

src/helpers/walletKitUtil.ts:566

• For exceptions raised while parsing or signing, dappDomain is still undefined because it is assigned only after signing returns. Consequently this failure path also drops origin; resolve the session metadata before entering the signing try so both failure forms receive it.

    // Signing threw. The user already approved the prompt, so this is a fault
    // and not a decision.
    analytics.trackSignedTransactionError({
      error: errorMessage,
      ...(dappDomain ? { dappDomain } : {}),

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Suppressed comments (1)

src/services/analytics/transactions.ts:70

• The wallet-composed collectible-send path is still uninstrumented: SendCollectibleReview.tsx calls signTransaction but emits none of these approved/rejected/failed signing events. As a result, the stated “every transaction” funnel—and the companion PR’s explicit collectible-send case—remains incomplete. Please wire all three outcomes into that review flow as well.

export const trackInternalSignedTransaction = (): void => {
  track(AnalyticsEvent.SIGN_TRANSACTION_SUCCESS, { source: "internal" });

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Suppressed comments (2)

Previously missed (1) — in code that hasn't changed since the last review.

src/services/analytics/transactions.ts:52

• This JSDoc still lists collectible sends as an emitting internal flow, but the PR explicitly keeps collectible signing uninstrumented and instead adds trustline changes. Update the examples so callers and analytics consumers do not infer unsupported collectible coverage.

src/components/screens/AddTokenScreen/AddTokenScreen.tsx:402

• This dismissal also runs for the CannotRemoveTokenBottomSheet branches used by native assets and assets with a positive balance (lines 240–268). Those sheets offer no approval and never attempt signing, but promptSigns is true for these non-custom tokens, so closing the informational sheet is incorrectly counted as a signing rejection. Gate this event on whether the removable confirmation content was actually shown.

            onDismiss: () => reportDismissal(hasApprovedRemoveRef),

[Copilot]

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

src/helpers/walletKitUtil.ts:540

• The new test passes dappDomain directly to the analytics helper, so it does not verify this integration—the exact area that previously lost attribution because metadata was resolved after signing. Add an approveSessionRequest test that makes signing return null (and throw) and asserts trackSignedTransactionError receives the resolved website domain.
  src/services/analytics/transactions.ts:52
• This docstring says collectible sends emit internal signing events, but the PR explicitly leaves collectible sends uninstrumented. That makes the public SigningSource documentation inaccurate; list only the internal flows currently covered.

[Copilot]

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.