-
Notifications
You must be signed in to change notification settings - Fork 18
Chore/3034123 #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Chore/3034123 #664
Changes from 15 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
29377db
add login performance entry analysis
leofelix077 8b9454e
clean up performance logging and add switch accounts loading screen
leofelix077 bc7959e
remove commented out code
leofelix077 e12b570
simplify logic of updating temporary store
leofelix077 50efd89
add wallet switching data clearing and wallet-based caching
leofelix077 9967c41
add wallet switching data clearing and wallet-based caching
leofelix077 1012842
update flow comments
leofelix077 d6d3610
cleanup bio pw typings
leofelix077 0338279
cleanup unused functions
leofelix077 bf982f5
simplify functions JSdocs
leofelix077 8dd8f42
remove caching of temp store
leofelix077 532a1bf
remove cache revalidation
leofelix077 49dc812
add locked state with preserved data
leofelix077 69430bd
remove history fetch for unfunded accounts
leofelix077 1b6b60c
Merge branch 'main' into chore/3034123
leofelix077 572bbfa
fix login after app update from signed out state
leofelix077 d7207b9
Merge branch 'chore/3034123' of github.com:stellar/freighter-mobile i…
leofelix077 691539f
fix minor issues from copilot review
leofelix077 a8f194b
fix copilot security checks
leofelix077 24f39d5
improve locked state data encryption
leofelix077 345429a
Merge branch 'main' into chore/3034123
leofelix077 ba9078f
Update src/ducks/auth.ts
leofelix077 d04c380
Update src/ducks/auth.ts
leofelix077 143b567
fix mocks for auth locked state test
leofelix077 9c2da1c
Merge branch 'main' into chore/3034123
leofelix077 9ec5c98
Update src/ducks/auth.ts
leofelix077 1377563
update used translations and add reset store tests
leofelix077 cc13085
Fix Podfile checksum
CassioMG 706291c
merge main into branch
leofelix077 2d11bdb
Merge branch 'chore/3034123' of github.com:stellar/freighter-mobile i…
leofelix077 b525d7f
clear all data on wallet import
leofelix077 1b345c8
fix fetch account balances
leofelix077 126dae2
Merge branch 'main' into chore/3034123
leofelix077 03bf5a2
disable multiple presses on account switch
leofelix077 9c0d5c0
Update src/ducks/auth.ts
leofelix077 8fa0a70
Merge branch 'main' of github.com:stellar/freighter-mobile into chore…
leofelix077 1749dff
Merge branch 'chore/3034123' of github.com:stellar/freighter-mobile i…
leofelix077 5f0f5ac
improve account switching UX
leofelix077 36371d4
add local spinner on account item to switch acct
leofelix077 d759293
adjust opacity on selected account
leofelix077 56da140
update acct change animation
leofelix077 efe975a
revert enable pan down to close
leofelix077 b800d30
Merge branch 'main' of github.com:stellar/freighter-mobile into chore…
leofelix077 30d104c
move persisted auth status to secure storage
leofelix077 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new LOCKED auth status and its associated behaviors (preserving temporary store on logout, handling unlock flow with shouldCreateTempStore parameter, lazy loading of private keys) lack test coverage. The existing test file tests/ducks/auth.test.ts should be updated to include tests for: 1) logout with LOCKED state preservation, 2) sign-in from LOCKED state, 3) getAuthStatus returning LOCKED when persisted, 4) lazy loading of private keys in getActiveAccount, and 5) account switching with the isSwitchingAccount flag.