Skip to content

Release 5.33.7 #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aristidesstaffieri merged 2 commits into from
Jul 31, 2025
Merged

Release 5.33.7 #2168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ba964e
still runs migrations if semver check fails for all previous migratio…
aristidesstaffieri Jul 31, 2025
71e3a25
updates test for migrations helper changes
aristidesstaffieri Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extension/src/background/helpers/__tests__/migrations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ describe("Storage migrations", () => {
expect(storedNetworks[NETWORKS_LIST_ID]).toBeUndefined;
});
it("migrateToAccountSubscriptions should set an empty map for account subscriptions", async () => {
await mockStorage.set({ [STORAGE_VERSION]: "3.0.0" });
await mockStorage.set({ [STORAGE_VERSION]: "2.9.0" });
await DataStorage.migrateToAccountSubscriptions();
const storedAccountSubs = await mockStorage.get(HAS_ACCOUNT_SUBSCRIPTION);
expect(storedAccountSubs[HAS_ACCOUNT_SUBSCRIPTION]).toEqual({});
Expand Down Expand Up @@ -209,7 +209,7 @@ describe("Storage migrations", () => {
expect(storedVersion[STORAGE_VERSION]).toEqual("4.0.1");
});
it("resetAccountSubscriptions should reset accoutn subscriptions at storage versions 4.0.2", async () => {
await mockStorage.set({ [STORAGE_VERSION]: "4.0.2" });
await mockStorage.set({ [STORAGE_VERSION]: "4.0.1" });
await DataStorage.resetAccountSubscriptions();
const storedAccountSubs = await mockStorage.get(HAS_ACCOUNT_SUBSCRIPTION);
expect(storedAccountSubs[HAS_ACCOUNT_SUBSCRIPTION]).toEqual({});
Expand Down
16 changes: 8 additions & 8 deletions extension/src/background/helpers/dataStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export const migrateTokenIdList = async () => {
const tokenIdsByKey = await localStore.getItem(TOKEN_ID_LIST);
const storageVersion = (await localStore.getItem(STORAGE_VERSION)) as string;

if (!storageVersion || semver.lt(storageVersion, "1.0.0")) {
if (shouldRunMigration({ storageVersion, migrationVersion: "1.0.0" })) {
if (Array.isArray(tokenIdsByKey)) {
const newTokenList = {
[NETWORKS.FUTURENET]: tokenIdsByKey,
Expand All @@ -122,7 +122,7 @@ export const migrateTestnetSorobanRpcUrlNetworkDetails = async () => {
const localStore = dataStorageAccess(browserLocalStorage);
const storageVersion = (await localStore.getItem(STORAGE_VERSION)) as string;

if (!storageVersion || semver.lt(storageVersion, "2.0.0")) {
if (shouldRunMigration({ storageVersion, migrationVersion: "2.0.0" })) {
const networksList: NetworkDetails[] =
(await localStore.getItem(NETWORKS_LIST_ID)) || DEFAULT_NETWORKS;

Expand Down Expand Up @@ -153,7 +153,7 @@ export const migrateToAccountSubscriptions = async () => {
const storageVersion = (await localStore.getItem(STORAGE_VERSION)) as string;

// we only want to run this once per user
if (!storageVersion || semver.eq(storageVersion, "3.0.0")) {
if (shouldRunMigration({ storageVersion, migrationVersion: "3.0.0" })) {
// once account is unlocked, setup Mercury account subscription if !HAS_ACCOUNT_SUBSCRIPTION
await localStore.setItem(HAS_ACCOUNT_SUBSCRIPTION, {});
}
Expand All @@ -163,7 +163,7 @@ export const migrateMainnetSorobanRpcUrlNetworkDetails = async () => {
const localStore = dataStorageAccess(browserLocalStorage);
const storageVersion = (await localStore.getItem(STORAGE_VERSION)) as string;

if (!storageVersion || semver.lt(storageVersion, "4.0.0")) {
if (shouldRunMigration({ storageVersion, migrationVersion: "4.0.0" })) {
const networksList: NetworkDetails[] =
(await localStore.getItem(NETWORKS_LIST_ID)) || DEFAULT_NETWORKS;

Expand Down Expand Up @@ -193,7 +193,7 @@ export const migrateSorobanRpcUrlNetwork = async () => {
const localStore = dataStorageAccess(browserLocalStorage);
const storageVersion = (await localStore.getItem(STORAGE_VERSION)) as string;

if (!storageVersion || semver.lt(storageVersion, "4.0.1")) {
if (shouldRunMigration({ storageVersion, migrationVersion: "4.0.1" })) {
// an edge case exists in `migrateSorobanRpcUrlNetworkDetails` where we may have updated the `networksList` in storage,
// but not the `network`, which is the current active network,
// If a user has Futurenet selected by default, they will not have sorobanRpcUrl set
Expand All @@ -215,7 +215,7 @@ export const resetAccountSubscriptions = async () => {
const localStore = dataStorageAccess(browserLocalStorage);
const storageVersion = (await localStore.getItem(STORAGE_VERSION)) as string;

if (!storageVersion || semver.eq(storageVersion, "4.0.2")) {
if (shouldRunMigration({ storageVersion, migrationVersion: "4.0.2" })) {
// once account is unlocked, setup Mercury account subscription if !HAS_ACCOUNT_SUBSCRIPTION
await localStore.setItem(HAS_ACCOUNT_SUBSCRIPTION, {});
await migrateDataStorageVersion("4.0.2");
Expand All @@ -226,7 +226,7 @@ export const addAssetsLists = async () => {
const localStore = dataStorageAccess(browserLocalStorage);
const storageVersion = (await localStore.getItem(STORAGE_VERSION)) as string;

if (!storageVersion || semver.lt(storageVersion, "4.1.0")) {
if (shouldRunMigration({ storageVersion, migrationVersion: "4.1.0" })) {
// add the base asset lists
await localStore.setItem(ASSETS_LISTS_ID, DEFAULT_ASSETS_LISTS);
await migrateDataStorageVersion("4.1.0");
Expand All @@ -237,7 +237,7 @@ export const addIsHashSigningEnabled = async () => {
const localStore = dataStorageAccess(browserLocalStorage);
const storageVersion = (await localStore.getItem(STORAGE_VERSION)) as string;

if (!storageVersion || semver.lt(storageVersion, "4.1.1")) {
if (shouldRunMigration({ storageVersion, migrationVersion: "4.1.1" })) {
// add the base asset lists
await localStore.setItem(IS_HASH_SIGNING_ENABLED_ID, false);
await migrateDataStorageVersion("4.1.1");
Expand Down
Loading