[Emergency Release] v5.48.0 - #2996
Conversation
There was a problem hiding this comment.
Pull request overview
Prepares extension metadata for emergency release v5.48.0, but does not yet include or describe the emergency fix.
Changes:
- Bumps extension package version to 5.48.0.
- Updates Manifest V3 version fields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
extension/package.json |
Bumps package version. |
extension/public/static/manifest/v3.json |
Bumps browser extension versions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
PR Preview build is ready: https://github.com/stellar/freighter/releases/tag/untagged-aad3356b6cd8cbfd5022 (SDF collaborators only — install instructions in the release description) |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
extension/src/background/messageListener/handlers/getCachedAssetIconList.ts:58
- Filtering these entries only from the response leaves each stale
nullon disk. When the subsequent lookup succeeds through issuer metadata rather than a token list,getAssetIconsupdates only Redux and never replaces the background entry, so every popup reload repeats the token-list, Horizon, and stellar.toml lookups. Please migrate/delete stale nulls and persist successful fallback results (or use an expiring negative-cache entry) instead of permanently hiding them at read time.
icons: Object.fromEntries(
Object.entries(assetIconCache).filter(([, iconUrl]) => iconUrl),
…rt) (#2997) * feat: add USDT0 launch banner and promo sheet to Home (v5.48.0) Backport of #2990 onto the v5.48.0 release branch so the promo can ship with that release. Applied as a single squashed commit; the tree for the 17 touched files is identical to the master-based branch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: fail closed on USDT0 banner dismissal lookup, announce the dialog Backport of #2999 onto the v5.48.0 release branch, addressing the review comments left on #2990 after it merged. The three touched files match the master-based fix branch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 23 changed files in this pull request and generated 3 comments.
Suppressed comments (2)
extension/src/background/messageListener/handlers/getCachedAssetIconList.ts:59
- Filtering every negative-cache entry here makes every genuinely iconless asset a fresh miss whenever the popup is reopened. The icon-enabled send, swap, history, and asset-management flows then repeat token-list, Horizon, and potentially stellar.toml requests indefinitely. Preserve negative entries with an expiry, or migrate only the affected stale USDT0 entry while changing the write path so failures cannot become permanent.
icons: Object.fromEntries(
Object.entries(assetIconCache).filter(([, iconUrl]) => iconUrl),
),
extension/src/popup/components/account/Usdt0LaunchBanner/index.tsx:50
- The local dismissed state changes only after persistence succeeds, so a transient messaging/storage failure makes the X button appear to do nothing. Hide the banner optimistically before awaiting persistence, as
useDiscoverWelcome.ts:28-35does; a later popup can show it again if the write failed.
const handleDismiss = async () => {
try {
const { isDismissed } = await dismissUsdt0LaunchBanner();
setIsDismissed(isDismissed);
} catch (error) {
Uh oh!
There was an error while loading. Please reload this page.