[New Tx Flow] Wire sign auth entries to Simulation & Validate Steps#1989
Merged
jeesunikim merged 4 commits intofeature/new-tx-flowfrom Apr 1, 2026
Merged
[New Tx Flow] Wire sign auth entries to Simulation & Validate Steps#1989jeesunikim merged 4 commits intofeature/new-tx-flowfrom
jeesunikim merged 4 commits intofeature/new-tx-flowfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace placeholder envelope signing with actual authorizeEntry() logic: - Add customSignFn prop to SignTransactionXdr for auth-specific signing - SorobanAuthSigningCard calls authorizeEntry() per entry via customSignFn - SimulateStepContent assembles transaction after auth entries are signed - Remove incorrect SorobanAuthSigningCard from ValidateStepContent Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Preview is available here: |
|
Preview is available here: |
quietbits
approved these changes
Apr 1, 2026
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransactionStepperHow to test:
CDJ6WXER3J7IKSAYSP2BUERPTWBUKCHEUKI6UIZZNDIIQZXFM4JNJADC--
a: first party address (testnet account)--
b: second party address (testnet account)--
token_a— a token contract address--
token_b— a different token contract address--
amount_a— how much token A party a offers--
min_b_for_a— minimum token B that a accepts--
amount_b— how much token B party b offers--
min_a_for_b— minimum token A that b acceptsRule:
For example:
Successful Transaction: 45e4a506dba013c1dd754d592295ced2728385e8560f9a892d32decd1f22a269