Bumped jsonrpsee from 0.20 to 0.26#81
Closed
merkle-maren wants to merge 1 commit intostellar:mainfrom
Closed
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates the crate’s JSON-RPC networking stack to jsonrpsee 0.26 (and corresponding transitive networking deps), along with a minor tokio version requirement adjustment for compatibility with that upgrade.
Changes:
- Bumped
jsonrpsee-http-client/jsonrpsee-corefrom0.20.xto0.26.0. - Lowered the direct
tokioversion requirement from1.43.1to1.42. - Updated the public error type to use
jsonrpsee_core::ClientErrorand refreshedCargo.lockaccordingly.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/lib.rs |
Updates the Error::JsonRpc variant’s inner type for jsonrpsee 0.26 compatibility. |
Cargo.toml |
Bumps jsonrpsee deps and relaxes the tokio minimum version requirement. |
Cargo.lock |
Refreshes the resolved dependency graph for the jsonrpsee/hyper/rustls upgrades. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
59
to
61
| #[error(transparent)] | ||
| JsonRpc(#[from] jsonrpsee_core::Error), | ||
| JsonRpc(#[from] jsonrpsee_core::ClientError), | ||
| #[error("json decoding error: {0}")] |
Comment on lines
+60
to
61
| JsonRpc(#[from] jsonrpsee_core::ClientError), | ||
| #[error("json decoding error: {0}")] |
Member
|
Hey! Thanks for the pr. This upgrade is already available on the latest 26.0.0-rc.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps jsonrpsee from 0.20 to 0.26. Also lowers the tokio requirement from 1.43 to 1.42 for compatibility with jsonrpsee 0.26 — semver-compatible, so an app will still resolve to the newest available.
Why
Porting soroban-rs to run inside a WASIp2 runtime. That depends on an unmerged tokio branch; there's an open PR on jsonrpsee tracking it. Full WASIp2 support comes in a later PR once that's stable. This update is non-breaking and is a required dependency of that work — no reason to block it.
Known limitations
N/A