Add IntoIterator impls for VecM by value and ref#514
Open
leighmcculloch wants to merge 1 commit intomainfrom
Open
Add IntoIterator impls for VecM by value and ref#514leighmcculloch wants to merge 1 commit intomainfrom
leighmcculloch wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing Rust-idiomatic iteration support for VecM<T, MAX> to match standard collection ergonomics and address #459.
Changes:
- Implement
IntoIteratorforVecM<T, MAX>by value underalloc(delegates to innerVec<T>iterator). - Implement
IntoIteratorfor&VecM<T, MAX>(returnscore::slice::Iter). - Add integration tests covering owned iteration, reference iteration, and
forloop usage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| xdr-generator/generator/header.rs | Adds the new IntoIterator impls to the generator header so future regeneration includes them. |
| src/curr/generated.rs | Applies the new IntoIterator impls to the current XDR channel generated output. |
| src/next/generated.rs | Applies the new IntoIterator impls to the next XDR channel generated output. |
| tests/vecm.rs | Adds tests validating both owned and shared-ref iteration behavior and for loop support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add two
IntoIteratorimplementations forVecM<T, MAX>: one that consumes the value (gated on theallocfeature, delegating to the innerVec's iterator), and one for shared references (returning acore::slice::Iter). The impls are added to the generator header and both generated files (currandnext). Tests cover owned iteration, reference iteration, andforloop usage.Why
VecMpreviously only implementedIntoIteratorfor&mut VecM, leavingfor item in vecmandfor item in &vecmunsupported. Callers had to call.iter()explicitly or dereference to a slice, which was inconsistent with standard Rust collection ergonomics.Close #459