-
Notifications
You must be signed in to change notification settings - Fork 39
Add const XDR serialization #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leighmcculloch
wants to merge
77
commits into
main
Choose a base branch
from
const-only-xdr-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
77 commits
Select commit
Hold shift + click to select a range
78e1d71
add borrowed Ref variants of generated types
leighmcculloch 3c2c077
fix VecMRef Copy bound and cfg-branch Ref lifetime
leighmcculloch 1fd5d24
impl WriteXdr for Ref types
leighmcculloch 552d5d0
format ref_types test with rustfmt
leighmcculloch d6774bc
regenerate Ref types without ungated CAP cfgs
leighmcculloch b6bf245
alias Ref types that do not borrow
leighmcculloch 61db46c
rename borrowing Ref types to View
leighmcculloch 6580c72
emit View only for unconditional borrowers
leighmcculloch 69ec52c
give View const try_from_slice/try_from_str
leighmcculloch 19442e2
rename View panic ctors to try_from_*_or_panic
leighmcculloch bc91d27
use xdr size consts in View types
leighmcculloch d4f6049
rewrite View tests around mirror invariants
leighmcculloch 7da9d61
convert Views to owned through an IntoOwned trait
leighmcculloch 1fb121d
make IntoOwned crate-private
leighmcculloch 152bc05
convert Views to owned from a reference
leighmcculloch b95b6b4
box cyclic View fields at the call site
leighmcculloch 9c3fd4c
convert Views to owned by value
leighmcculloch e4090fc
spell out the identity IntoOwned impls
leighmcculloch 75ffca2
trim redundancy from the View tests
leighmcculloch 01a42aa
remove doc
leighmcculloch dd3daa9
rewrite View tests around owned mirrors
leighmcculloch d1722e1
gate the View tests by feature
leighmcculloch 71095d8
rename the View suffix to Ref
leighmcculloch 35fc497
share the envelope fixture between tests
leighmcculloch 629d891
rename ref and owned fixture helpers
leighmcculloch e3144c7
format transactionenvelope in doc comment
leighmcculloch 6b51bfd
put const XDR encoding on ConstWriter
leighmcculloch 4db69f5
render const writer methods from the template
leighmcculloch c0e860d
carry the Ref rename into the const writer
leighmcculloch 552499c
check const bytes against a hand-built owned
leighmcculloch d2318f0
shrink const xdr test suite to single envelope test that covers all b…
leighmcculloch b2bc25d
hand-write the scalar option and vec writers
leighmcculloch 2c50bb3
drop the const writer's residual module path
leighmcculloch 0c498db
simplify the const writer template
leighmcculloch e384b9b
turn Ref types into const-only Const types
leighmcculloch c7f453b
emit a Const form for cfg-gated heap types
leighmcculloch 3b92d6d
Merge branch 'main' into const-only-xdr-types
leighmcculloch ee1136e
gate generated Const types behind const feature
leighmcculloch fc8753d
move const types into a const module, drop suffix
leighmcculloch 881a386
document the const feature
leighmcculloch c8935d0
derive Arbitrary for the const types
leighmcculloch ec72926
assert const unit tests on the const module
leighmcculloch 2541a29
add differential fuzz targets for const encoding
leighmcculloch 9caab08
merge main, porting const output onto generate_files
leighmcculloch 87ef0ff
derive const_type at use sites, drop the field
leighmcculloch 5711c0e
run the fuzz corpus in ci
leighmcculloch dd44273
shorten asan leak detection comment
leighmcculloch 4bdc302
move fuzzing config from github actions to makefile
leighmcculloch 1273121
replace assertion with panic for mismatched construction
leighmcculloch 5c4f04d
add leak justification comments to arbitrary impls
leighmcculloch d1c9e83
switch xdr types to const only
leighmcculloch c4b4ddb
fuzz
leighmcculloch f885036
reduce corpus using claude and json repr
leighmcculloch 6c49dc9
implement arbitrary for const generic xdr types and fix arb for owned…
leighmcculloch 6971048
remove generator source prerequisites from generated.rs rule
leighmcculloch 7bb95e2
remove mut from konst_xdr_len
leighmcculloch 7d54aaa
remove ledger-close-meta and transaction-envelope fuzz targets
leighmcculloch 13366c9
match owned and const xdr errors
leighmcculloch 194cf20
add fuzz-corpus-json target
leighmcculloch ee204d4
remove extra blank line in Makefile
leighmcculloch 633ccc7
fix malformed backslash in makefile loop
leighmcculloch e1594b6
remove fuzz-corpus-json make target
leighmcculloch 2d8f34f
remove transaction-envelope and ledger-close-meta fuzz targets
leighmcculloch 17093ad
delete const_arbitrary.rs test
leighmcculloch a6d6788
add const and owned spec entry test values
leighmcculloch cc186fb
pass loop depth to const encode
leighmcculloch 89e7cd9
Fix error message for missing generated file
leighmcculloch fd816e9
remove fuzz-coverage make target
leighmcculloch ad3f39b
replace transaction-envelope with spec-entry in fuzz readme
leighmcculloch d456264
remove write_xdr impl for &T
leighmcculloch 24d67b0
Merge remote-tracking branch 'origin/const-only-xdr-types' into const…
leighmcculloch ac5f13b
add const to xdr type imports
leighmcculloch 6eded8f
add const to xdr types
leighmcculloch 40a63ed
use rand for test data generation
leighmcculloch ca6ca37
remove fuzz-corpus-json target
leighmcculloch e6b65f5
Merge remote-tracking branch 'origin/main' into const-only-xdr-types
leighmcculloch c0e9639
regenerate const module after merging main
leighmcculloch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| target | ||
| artifacts | ||
| coverage |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.