Resume ballot on top of overlay v2 - #5416
Closed
marta-lokhova wants to merge 4 commits into
Closed
Conversation
This change allows stellar-core to quickly resume balloting when a transaction set arrives, rather than waiting for a ballot timeout to resume. It creates a registry of stalled slots, and checks tx sets that arrive to see if they could potentially unstick those slots. A stall can only be resolved by a tx set if the ballot protocol has not undergone any changes since hitting the stall point. This prevents prevents us from resuming with a ballot when the node may have moved on to a different value. This change also adds `c` to the calculation of ballot ordering. This is necessary because without it, a node that exercises this quick-resume path has no way of informing the network as they will discard a ballot where the other variables are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick up @bboston7's changes from #5346 for testing