merge release/28.0.1-internal to master - #5440
Merged
Merged
Conversation
Resolves #704. This PR clamps the results of `ApplicableTxSetFrame::getTotalFees` and `ApplicableTxSetGrame::getTotalInclusionFees` to `INT64_MAX` so that these functions do not overflow. The only caller of these functions is `compareTxSets`, and the only caller of that function is `HerderSCPDriver::combineCandidates`. I think this is why #704 ascribes the bug to `combineCandidates`, but I'd argue it's lower down in these fee summing functions. I've verified that this fixes the PoC in #704. The unit test I added is much more targeted; it focuses on the underlying functions themselves.
Deduplicate query messages
Skip background tx sig verification for unauthenticated peers
Clamp additions in tx set fee summing functions
graydon
enabled auto-merge
September 2, 2026 20:26
bboston7
approved these changes
Sep 2, 2026
anupsdf
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge release/28.0.1-internal to master