chore: fix JS SDK default import for @stellar/stellar-sdk v16.0.0 - #2521
Merged
Merged
Conversation
js-stellar-sdk v16.0.0 removed the ESM default export (and merged @stellar/stellar-base into @stellar/stellar-sdk). The string-to-ScVal example used `import StellarSdk from "@stellar/stellar-sdk"`, which no longer works. Switch to a namespace import (`import * as StellarSdk`) to preserve the `StellarSdk.xdr.ScVal` body unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Stellar JS SDK import style in the “string to ScVal” conversion guide to stay compatible with @stellar/stellar-sdk v16.0.0, which removed the ESM default export.
Changes:
- Replaced the default ESM import with a namespace import (
import * as StellarSdk from "@stellar/stellar-sdk") in the JS example to keepStellarSdk.xdr.ScVal...usage unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ```js | ||
| import StellarSdk from "@stellar/stellar-sdk"; | ||
| import * as StellarSdk from "@stellar/stellar-sdk"; |
|
Preview is available here: |
briwylde08
approved these changes
Jun 17, 2026
zachfedor
pushed a commit
to zachfedor/stellar-docs
that referenced
this pull request
Jun 18, 2026
…ellar#2521) js-stellar-sdk v16.0.0 removed the ESM default export (and merged @stellar/stellar-base into @stellar/stellar-sdk). The string-to-ScVal example used `import StellarSdk from "@stellar/stellar-sdk"`, which no longer works. Switch to a namespace import (`import * as StellarSdk`) to preserve the `StellarSdk.xdr.ScVal` body unchanged. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
js-stellar-sdk v16.0.0 removed the ESM default export (and merged @stellar/stellar-base into @stellar/stellar-sdk). The string-to-ScVal example used
import StellarSdk from "@stellar/stellar-sdk", which no longer works. Switch to a namespace import (import * as StellarSdk) to preserve theStellarSdk.xdr.ScValbody unchanged.