Skip to content

deprecated note to use amount_raw - #2632

Merged
ElliotFriend merged 2 commits into
mainfrom
minor/deprecate-token-transfers-amount
Jul 17, 2026
Merged

ElliotFriend merged 2 commits into
mainfrom
minor/deprecate-token-transfers-amount

Conversation

@ttboogie

@ttboogie ttboogie commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Add a deprecation note to the amount column in the Hubble data dictionary (silver/token-transfers-raw.mdx), pointing readers to amount_raw.

amount hardcodes a fixed 7-decimal scale in stellar-etl regardless of the token's declared decimals, so this public column is wrong for any non-7-decimal token. amount_raw is always correct. The dictionary entry previously described amount with no caveat.

Sibling PRs: stellar/stellar-etl-airflow#956 (BQ column description), stellar/stellar-dbt-public#301 (dbt docs).

Note: English source only. The Spanish translation (i18n/es/...) is Crowdin-managed, so it's left for that flow.

Copilot AI review requested due to automatic review settings July 17, 2026 18:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documents the deprecated amount field and directs users to correctly scale amount_raw.

Changes:

  • Explains the fixed seven-decimal limitation.
  • Recommends scaling raw values using token decimals.

@stellar-jenkins-ci

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@stellar-jenkins-ci

Copy link
Copy Markdown

@ElliotFriend
ElliotFriend merged commit 8003ee3 into main Jul 17, 2026
11 checks passed
@ElliotFriend
ElliotFriend deleted the minor/deprecate-token-transfers-amount branch July 17, 2026 19:16
@ElliotFriend
ElliotFriend restored the minor/deprecate-token-transfers-amount branch July 17, 2026 19:18
@ElliotFriend
ElliotFriend deleted the minor/deprecate-token-transfers-amount branch July 17, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants