Protocol 28 GA: remaining pins + release workflow fix - #211
Merged
Merged
Conversation
…ease workflow fix - verify-range STELLAR_CORE_VERSION → 28.0.0-3486.2332980a1.noble (the integration legs' pins were already flipped on protocol-next) - go-stellar-sdk → v0.6.1-0.20260803175255-2b16db0ecd45 (P28 GA merge); loadtest call sites migrated to the multi-bundle LedgersFilePaths API (go-stellar-sdk#5959) - horizon-release.yml: strip 'v' (not 'horizon-v') from the tag so VERSION and the deprecation grep are correct — latent since the tag rename (#144) - CHANGELOG: Unreleased → 28.0.0 Train: stellar/go-stellar-sdk#5967 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
31 tasks
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
karthikiyer56
approved these changes
Aug 3, 2026
Testing the previous protocol against the previous core is redundant — the prev leg exists to verify the NEW core binary still serves protocol 27. Both legs now run 28.0.0-3486.2332980a1 (via unsafe-stellar-core until the GA-repo image publishes). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Per release-train convention (now codified): the P27 leg runs the updated 28.0.0 core rather than the old 27.1.0 — the previous-protocol leg's job is verifying the new binary serves the old protocol; old-core-on-old-protocol re-tests what already shipped. |
Contributor
Author
|
Heads-up on the P28 leg's rpc image: |
Same reasoning as the core bump: the N-1 leg verifies the updated binaries serve the previous protocol (the real upgrade-window configuration). The new rpc supports P27 via its -prev host. Both legs' rpc pins get replaced by the compatible post-flip image once stellar/stellar-rpc#913 merges. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Protocol 28 GA release train (stellar/go-stellar-sdk#5967). The integration-leg core/rpc pins were already flipped on protocol-next; this covers the rest:
verify-rangeSTELLAR_CORE_VERSION→28.0.0-3486.2332980a1.noblego-stellar-sdk→v0.6.1-0.20260803175255-2b16db0ecd45(P28 GA merge commit; re-pins tov0.7.0before the main merge once the SDK release exists). Loadtest call sites (internal/ingest/main.go,ingestion_load_test.go) migrated to the multi-bundleLedgersFilePathsAPI from go-stellar-sdk#5959.horizon-release.yml:VERSION=${GITHUB_REF_NAME#horizon-v}→#v— the strip has been a no-op since tags dropped thehorizon-prefix (Fix horizon-release github action #144), so the release workflow grepped for the wrong deprecation marker.Unreleased→28.0.0with the protocol headline.MaxSupportedProtocolVersionverified already at 28;load-test-ledgers-v28/unlimited-config-v28fixtures verified present.Note: the P28 integration leg cannot go green until
stellar/stellar-core:28.0.0-3486.2332980a1.jammyis published on Docker Hub (still 404 — tracked on the train issue).go build ./..., integration-tagged compile, and the fullinternal/ingestsuite pass locally.🤖 Generated with Claude Code