Bump go-stellar-sdk to pick up XDR asset ordering fix - #218
Merged
Merged
Conversation
Picks up stellar/go-stellar-sdk#5974, which fixes Asset.LessThan to compare assets by their XDR encoding (raw issuer key) instead of strkey text, and switches the token_transfer processor to value-based asset equality so trustline revocation burns the correct liquidity pool leg. Also carries the required go-xdr bump to v0.0.0-20260806060815-dc590f17552a. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Stellar dependencies to incorporate corrected XDR asset ordering and value-based liquidity-pool asset comparison.
Changes:
- Pins
go-stellar-sdkto the merge commit containing the fixes. - Updates the required
go-xdrpseudo-version and checksums.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
go.mod |
Updates Stellar SDK and XDR dependency versions. |
go.sum |
Refreshes checksums for the updated modules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Shaptic
approved these changes
Aug 7, 2026
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
go-stellar-sdkfromv0.7.0tov0.7.2-0.20260806235222-d2f530f4327b(pseudo-version pinning the merge commit of go-stellar-sdk#5974, no tag contains it yet).go-xdrbump that PR requires:v0.0.0-20260806060815-dc590f17552a.Why
Asset.LessThanto compare assets by their XDR encoding (raw 32-byte issuer key) instead of base32 strkey text.token_transferprocessor to value-based asset equality, so trustline revocation burns the correct liquidity pool leg.Verification
go build ./...passes.go test ./internal/ingest/... ./internal/db2/history/...passes (covers the processors affected by the SDK's asset-comparison changes).🤖 Generated with Claude Code