Pin shadow to x/tools v0.49.0 so govet runs on Go 1.25 - #232
Merged
Merged
Conversation
Shaptic
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goshadow.shrunsshadow@latest. x/tools v0.50.0 (2026-09-08) requires Go 1.26, so the Go 1.25checkleg fails ingovet.shwithgo: can't execute goshadow.sh. Same failure onmainsince the 2026-09-17 runs; last green run was 2026-09-04 on v0.49.0.Pins shadow to v0.49.0, the last x/tools release that builds on Go 1.25 (
go.modisgo 1.25.0).E.g broken job on main: https://github.com/stellar/stellar-horizon/actions/runs/35254665150/job/105315215827